From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:46356 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbdLLWOv (ORCPT ); Tue, 12 Dec 2017 17:14:51 -0500 Date: Tue, 12 Dec 2017 14:09:45 -0800 From: Liu Bo To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: Remove pair of bio_get/put in btrfs_schedule_bio Message-ID: <20171212220944.GA19371@lim.localdomain> Reply-To: bo.li.liu@oracle.com References: <1513003128-15489-1-git-send-email-nborisov@suse.com> <20171211225756.GA6827@lim.localdomain> <20171212185238.GR3553@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171212185238.GR3553@twin.jikos.cz> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Dec 12, 2017 at 07:52:38PM +0100, David Sterba wrote: > On Mon, Dec 11, 2017 at 02:57:56PM -0800, Liu Bo wrote: > > On Mon, Dec 11, 2017 at 04:38:48PM +0200, Nikolay Borisov wrote: > > > This code was added in 492bb6deee34 ("Btrfs: Hold a reference on bios > > > during submit_bio, add some extra bio checks"). However, holding a > > > reference on a bio is necessary only if it's going to be referenced > > > after the submit_bio returns and the bio is completed. In this > > > particular instance this is not the case so there is no need to hold > > > an extra reference since we directly return. > > > > > > > Looks good. If possible, please also drop other unnecessary bio_get() > > in btrfs. > > You mean everywhere with similar context like in this patch? > Right, there're several places where bio_get() is put before running functions but bio_put() is also put immediately without referencing bio. thanks, -liubo