From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 3/3] btrfs: misc cleanup btrfs_scan_one_device()
Date: Fri, 15 Dec 2017 15:40:16 +0800 [thread overview]
Message-ID: <20171215074016.26461-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20171215074016.26461-1-anand.jain@oracle.com>
Assign ret = -EINVAL where actually its required.
Remove { } around single line if else code.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index a7eb9b42cd92..ba06a4ccd5a6 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1173,7 +1173,7 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
struct btrfs_super_block *disk_super;
struct block_device *bdev;
struct page *page;
- int ret = -EINVAL;
+ int ret;
u64 devid;
u64 transid;
u64 total_devices;
@@ -1192,8 +1192,10 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
if (IS_ERR(bdev))
return PTR_ERR(bdev);
- if (btrfs_read_disk_super(bdev, bytenr, &page, &disk_super))
+ if (btrfs_read_disk_super(bdev, bytenr, &page, &disk_super)) {
+ ret = -EINVAL;
goto error_bdev_put;
+ }
devid = btrfs_stack_device_id(&disk_super->dev_item);
transid = btrfs_super_generation(disk_super);
@@ -1206,11 +1208,10 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
mutex_unlock(&uuid_mutex);
if (ret > 0) {
- if (disk_super->label[0]) {
+ if (disk_super->label[0])
pr_info("BTRFS: device label %s ", disk_super->label);
- } else {
+ else
pr_info("BTRFS: device fsid %pU ", disk_super->fsid);
- }
pr_cont("devid %llu transid %llu %s\n", devid, transid, path);
ret = 0;
--
2.7.0
next prev parent reply other threads:[~2017-12-15 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 7:40 [PATCH 1/3] btrfs: make code easy to read in btrfs_open_one_device() Anand Jain
2017-12-15 7:40 ` [PATCH 2/3] btrfs: optimize move uuid_mutex closer to the critical section Anand Jain
2018-01-05 14:11 ` David Sterba
2017-12-15 7:40 ` Anand Jain [this message]
2018-01-05 14:14 ` [PATCH 3/3] btrfs: misc cleanup btrfs_scan_one_device() David Sterba
2018-01-05 14:09 ` [PATCH 1/3] btrfs: make code easy to read in btrfs_open_one_device() David Sterba
2018-01-22 4:11 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215074016.26461-3-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).