From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:40963 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbdLSTo6 (ORCPT ); Tue, 19 Dec 2017 14:44:58 -0500 Received: by mail-pg0-f66.google.com with SMTP id o2so10956090pgc.8 for ; Tue, 19 Dec 2017 11:44:58 -0800 (PST) Date: Tue, 19 Dec 2017 11:44:55 -0800 From: Omar Sandoval To: Nikolay Borisov Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, dsterba@suse.cz Subject: Re: [RFC PATCH] btrfs: qgroup: Deprecate the ability to manually inherit rfer/excl numbers Message-ID: <20171219194455.GC22017@vader.DHCP.thefacebook.com> References: <20171219104511.3563-1-wqu@suse.com> <20171219190125.GA19899@vader.DHCP.thefacebook.com> <20171219193658.GA22017@vader.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171219193658.GA22017@vader.DHCP.thefacebook.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Dec 19, 2017 at 11:36:58AM -0800, Omar Sandoval wrote: > On Tue, Dec 19, 2017 at 09:19:10PM +0200, Nikolay Borisov wrote: > > > > > > On 19.12.2017 21:01, Omar Sandoval wrote: > > > My only objection is that we shouldn't rename the field names in the > > > UAPI header. Let's just add a comment that the two counters are ignored. > > > Besides that, > > > > Why is that? > > We don't know if anyone is including the UAPI header and referring to > these fields for whatever reason. A quick Google search doesn't turn up > anything, but it has been there forever so I think we should err on the > side of not breaking the API. At least snapper sets these: https://github.com/openSUSE/snapper/blob/3c126c92bf2bd25a952800b2efb18754148ac227/snapper/BtrfsUtils.cc#L147 They get it from the libbtrfs header, but we might some day sync it to the UAPI header. So it's not completely theoretical :)