linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 4/5] btrfs: drop devid as device_list_add() arg
Date: Tue,  9 Jan 2018 22:46:24 +0800	[thread overview]
Message-ID: <20180109144625.28381-5-anand.jain@oracle.com> (raw)
In-Reply-To: <20180109144625.28381-1-anand.jain@oracle.com>

As struct btrfs_disk_super is being passed, so it can get devid
the same way its parent does.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 fs/btrfs/volumes.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2317ca1b3d83..f942e8193862 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -732,12 +732,13 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
  */
 static noinline int device_list_add(const char *path,
 			   struct btrfs_super_block *disk_super,
-			   u64 devid, struct btrfs_device **device_ret)
+			   struct btrfs_device **device_ret)
 {
 	struct btrfs_device *device;
 	struct btrfs_fs_devices *fs_devices;
 	struct rcu_string *name;
 	u64 found_transid = btrfs_super_generation(disk_super);
+	u64 devid = btrfs_stack_device_id(&disk_super->dev_item);
 
 	fs_devices = find_fsid(disk_super->fsid);
 	if (!fs_devices) {
@@ -1187,7 +1188,6 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 	struct block_device *bdev;
 	struct page *page;
 	int ret;
-	u64 devid;
 	u64 bytenr;
 
 	/*
@@ -1208,10 +1208,8 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 		goto error_bdev_put;
 	}
 
-	devid = btrfs_stack_device_id(&disk_super->dev_item);
-
 	mutex_lock(&uuid_mutex);
-	ret = device_list_add(path, disk_super, devid, &device);
+	ret = device_list_add(path, disk_super, &device);
 	mutex_unlock(&uuid_mutex);
 
 	*fs_devices_ret = device->fs_devices;
-- 
2.7.0


  parent reply	other threads:[~2018-01-09 14:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 14:46 [PATCH 0/5] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-09 14:46 ` [PATCH 1/5] btrfs: move pr_info into device_list_add Anand Jain
2018-01-09 16:12   ` Josef Bacik
2018-01-09 14:46 ` [PATCH 2/5] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-09 16:12   ` Josef Bacik
2018-01-09 14:46 ` [PATCH 3/5] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-09 16:13   ` Josef Bacik
2018-01-10  1:28     ` Anand Jain
2018-01-09 14:46 ` Anand Jain [this message]
2018-01-09 16:14   ` [PATCH 4/5] btrfs: drop devid as device_list_add() arg Josef Bacik
2018-01-09 14:46 ` [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity Anand Jain
2018-01-09 16:15   ` Josef Bacik
2018-01-10  1:38     ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109144625.28381-5-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).