From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity
Date: Tue, 9 Jan 2018 22:46:25 +0800 [thread overview]
Message-ID: <20180109144625.28381-6-anand.jain@oracle.com> (raw)
In-Reply-To: <20180109144625.28381-1-anand.jain@oracle.com>
move uuid_mutex with in device_list_add().
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index f942e8193862..283417bf3b00 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -740,6 +740,7 @@ static noinline int device_list_add(const char *path,
u64 found_transid = btrfs_super_generation(disk_super);
u64 devid = btrfs_stack_device_id(&disk_super->dev_item);
+ mutex_lock(&uuid_mutex);
fs_devices = find_fsid(disk_super->fsid);
if (!fs_devices) {
fs_devices = alloc_fs_devices(disk_super->fsid);
@@ -847,6 +848,8 @@ static noinline int device_list_add(const char *path,
fs_devices->total_devices = btrfs_super_num_devices(disk_super);
+ mutex_unlock(&uuid_mutex);
+
*device_ret = device;
return 0;
@@ -1208,9 +1211,7 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
goto error_bdev_put;
}
- mutex_lock(&uuid_mutex);
ret = device_list_add(path, disk_super, &device);
- mutex_unlock(&uuid_mutex);
*fs_devices_ret = device->fs_devices;
--
2.7.0
next prev parent reply other threads:[~2018-01-09 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:46 [PATCH 0/5] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-09 14:46 ` [PATCH 1/5] btrfs: move pr_info into device_list_add Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 2/5] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 3/5] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-09 16:13 ` Josef Bacik
2018-01-10 1:28 ` Anand Jain
2018-01-09 14:46 ` [PATCH 4/5] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-09 16:14 ` Josef Bacik
2018-01-09 14:46 ` Anand Jain [this message]
2018-01-09 16:15 ` [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity Josef Bacik
2018-01-10 1:38 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109144625.28381-6-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).