From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity
Date: Tue, 9 Jan 2018 11:15:21 -0500 [thread overview]
Message-ID: <20180109161520.vtv4zzljrxtv7cuw@destiny> (raw)
In-Reply-To: <20180109144625.28381-6-anand.jain@oracle.com>
On Tue, Jan 09, 2018 at 10:46:25PM +0800, Anand Jain wrote:
> move uuid_mutex with in device_list_add().
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
This isn't going to work, there's a bunch of places we return errors so this
just deadlocks the box. Leave it like it is, it's not hurting anybody leaving
it like this. Thanks,
Josef
next prev parent reply other threads:[~2018-01-09 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:46 [PATCH 0/5] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-09 14:46 ` [PATCH 1/5] btrfs: move pr_info into device_list_add Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 2/5] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 3/5] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-09 16:13 ` Josef Bacik
2018-01-10 1:28 ` Anand Jain
2018-01-09 14:46 ` [PATCH 4/5] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-09 16:14 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity Anand Jain
2018-01-09 16:15 ` Josef Bacik [this message]
2018-01-10 1:38 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109161520.vtv4zzljrxtv7cuw@destiny \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox