linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/4] btrfs: set the total_devices in device_list_add()
Date: Thu, 18 Jan 2018 22:02:34 +0800	[thread overview]
Message-ID: <20180118140236.25349-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20180118140236.25349-1-anand.jain@oracle.com>

There is no other parent for device_list_add() except for
btrfs_scan_one_device(), which would set btrfs_fs_devices::total_devices
if device_list_add is successful and this can be done with in
device_list_add() itself.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Josef Bacik <jbacik@fb.com>
---
 fs/btrfs/volumes.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 0b145276ff46..66e5dada2d74 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -843,6 +843,8 @@ static noinline int device_list_add(const char *path,
 	if (!fs_devices->opened)
 		device->generation = found_transid;
 
+	fs_devices->total_devices = btrfs_super_num_devices(disk_super);
+
 	*fs_devices_ret = fs_devices;
 
 	return 0;
@@ -1184,7 +1186,6 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 	struct page *page;
 	int ret;
 	u64 devid;
-	u64 total_devices;
 	u64 bytenr;
 
 	/*
@@ -1206,12 +1207,9 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 	}
 
 	devid = btrfs_stack_device_id(&disk_super->dev_item);
-	total_devices = btrfs_super_num_devices(disk_super);
 
 	mutex_lock(&uuid_mutex);
 	ret = device_list_add(path, disk_super, devid, fs_devices_ret);
-	if (!ret && fs_devices_ret)
-		(*fs_devices_ret)->total_devices = total_devices;
 	mutex_unlock(&uuid_mutex);
 
 	btrfs_release_disk_super(page);
-- 
2.7.0


  parent reply	other threads:[~2018-01-18 14:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 14:02 [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-18 14:02 ` [PATCH 1/4] btrfs: move pr_info into device_list_add Anand Jain
2018-01-18 14:02 ` Anand Jain [this message]
2018-01-18 14:02 ` [PATCH 3/4] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-18 14:02 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-18 17:47 ` [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device David Sterba
2018-01-19 23:27   ` David Sterba
2018-01-22 13:31     ` Anand Jain
2018-01-22 15:26       ` David Sterba
2018-01-22 21:52         ` Anand Jain
2018-04-20  6:22           ` Gu, Jinxiang
2018-04-20  6:58             ` Anand Jain
  -- strict thread matches above, loose matches on Subject: below --
2018-01-22 13:29 [PATCH v5 " Anand Jain
2018-01-22 13:29 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-10 22:53 [PATCH v4 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10 22:53 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-10  5:16 [PATCH v3 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10  5:16 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-10  1:49 [PATCH V2 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10  1:49 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118140236.25349-3-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).