From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not cache rbio pages if using raid6 recover
Date: Thu, 18 Jan 2018 16:17:11 +0100 [thread overview]
Message-ID: <20180118151711.GO13726@twin.jikos.cz> (raw)
In-Reply-To: <20180113010702.25612-2-bo.li.liu@oracle.com>
On Fri, Jan 12, 2018 at 06:07:02PM -0700, Liu Bo wrote:
> Since raid6 recover tries all possible combinations of failed stripes,
>
> - when raid6 rebuild algorithm is used, i.e. raid6_datap_recov() and
> raid6_2data_recov(), it may change the in-memory content of failed
> stripes, if such a raid bio is cached, a later raid write rmw or recover
> can steal @stripe_pages from it instead of reading from disks, such that
> it carries the wrong content to do write rmw or recovery and ends up
> with corruption or recovery failures.
>
> - when raid5 rebuild algorithm is used, i.e. xor, raid bio can be cached
> because the only failed stripe which contains @rbio->bio_pages gets
> modified, others remain the same so that their in-memory content is
> consistent with their on-disk content.
>
> This adds a check to skip caching rbio if using raid6 recover.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Added to 4.16 queue, thanks.
prev parent reply other threads:[~2018-01-18 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 1:07 [PATCH] Btrfs: do not cache rbio pages if using raid6 recover Liu Bo
2018-01-18 15:17 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118151711.GO13726@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).