linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 4/4] btrfs: drop devid as device_list_add() arg
Date: Mon, 22 Jan 2018 21:29:43 +0800	[thread overview]
Message-ID: <20180122132943.14729-5-anand.jain@oracle.com> (raw)
In-Reply-To: <20180122132943.14729-1-anand.jain@oracle.com>

As struct btrfs_disk_super is being passed, so it can get devid
the same way its parent does.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Josef Bacik <jbacik@fb.com>
---
 fs/btrfs/volumes.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index a86c3a14ec89..03f2685a5018 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -733,12 +733,13 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
  * error pointer when failed
  */
 static noinline struct btrfs_device *device_list_add(const char *path,
-			   struct btrfs_super_block *disk_super, u64 devid)
+			   struct btrfs_super_block *disk_super)
 {
 	struct btrfs_device *device;
 	struct btrfs_fs_devices *fs_devices;
 	struct rcu_string *name;
 	u64 found_transid = btrfs_super_generation(disk_super);
+	u64 devid = btrfs_stack_device_id(&disk_super->dev_item);
 
 	fs_devices = find_fsid(disk_super->fsid);
 	if (!fs_devices) {
@@ -1186,7 +1187,6 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 	struct block_device *bdev;
 	struct page *page;
 	int ret = 0;
-	u64 devid;
 	u64 bytenr;
 
 	/*
@@ -1207,10 +1207,8 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
 		goto error_bdev_put;
 	}
 
-	devid = btrfs_stack_device_id(&disk_super->dev_item);
-
 	mutex_lock(&uuid_mutex);
-	device = device_list_add(path, disk_super, devid);
+	device = device_list_add(path, disk_super);
 	mutex_unlock(&uuid_mutex);
 	if (IS_ERR(device))
 		ret = PTR_ERR(device);
-- 
2.7.0


  parent reply	other threads:[~2018-01-22 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 13:29 [PATCH v5 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-22 13:29 ` [PATCH 1/4] btrfs: move pr_info into device_list_add Anand Jain
2018-01-22 13:29 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-22 13:29 ` [PATCH 3/4] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-22 13:29 ` Anand Jain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-01-18 14:02 [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-18 14:02 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-10 22:53 [PATCH v4 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10 22:53 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-10  5:16 [PATCH v3 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10  5:16 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-10  1:49 [PATCH V2 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-10  1:49 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122132943.14729-5-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).