linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device
Date: Mon, 22 Jan 2018 16:26:43 +0100	[thread overview]
Message-ID: <20180122152642.GG15713@twin.jikos.cz> (raw)
In-Reply-To: <334ef632-a913-372b-a91b-826278329fc3@oracle.com>

On Mon, Jan 22, 2018 at 09:31:47PM +0800, Anand Jain wrote:
>   Problem was mainly due to the patch 3/4, which tried to access the
>   return pointer even for the failed condition. The fix is to bring the
>   device point access under the else part as show below [2]. I have
>   included this fix in V5. Which is tested with btrfs xfstests.
>   Pls could you consider v5 for 4.16 ?

Hm ok, thre's still some time to test it. One more fstests report that
appeared before and also with the v5:

btrfs/007 4s ...        [16:38:09] [16:38:12] [failed, exit status 1] - output mismatch (see /root/test/mmtests/work/sources/xfstests-git-installed/results//btrfs/007.out.bad)
    --- tests/btrfs/007.out     2017-09-20 14:24:58.334716658 +0200 
    +++ /root/test/mmtests/work/sources/xfstests-git-installed/results//btrfs/007.out.bad       2018-01-22 16:38:12.883931593 +0100
    @@ -1,4 +1,5 @@
     QA output created by 007
     *** test send / receive
    -*** done
    +failed: '/root/test/mmtests/work/sources/xfstests-git-installed/src/fssum -r /tmp/tmp.eZcr17wqNn/incr.fssum /root/test/mmtests/scratch_mnt/incr'
    +(see /root/test/mmtests/work/sources/xfstests-git-installed/results//btrfs/007.full for details)
     *** unmount
    ...
    (Run 'diff -u tests/btrfs/007.out /root/test/mmtests/work/sources/xfstests-git-installed/results//btrfs/007.out.bad'  to see the entire diff)

  reply	other threads:[~2018-01-22 15:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 14:02 [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-18 14:02 ` [PATCH 1/4] btrfs: move pr_info into device_list_add Anand Jain
2018-01-18 14:02 ` [PATCH 2/4] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-18 14:02 ` [PATCH 3/4] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-18 14:02 ` [PATCH 4/4] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-18 17:47 ` [PATCH RESEND v4 0/4] device_list_add() peparation to add reappearing missing device David Sterba
2018-01-19 23:27   ` David Sterba
2018-01-22 13:31     ` Anand Jain
2018-01-22 15:26       ` David Sterba [this message]
2018-01-22 21:52         ` Anand Jain
2018-04-20  6:22           ` Gu, Jinxiang
2018-04-20  6:58             ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122152642.GG15713@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).