From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f181.google.com ([209.85.216.181]:42519 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbeAZOFW (ORCPT ); Fri, 26 Jan 2018 09:05:22 -0500 Received: by mail-qt0-f181.google.com with SMTP id c2so1457444qtn.9 for ; Fri, 26 Jan 2018 06:05:21 -0800 (PST) Date: Fri, 26 Jan 2018 09:05:20 -0500 From: Josef Bacik To: Liu Bo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] Btrfs: fix extent state leak from tree log Message-ID: <20180126140520.3cyb53ttwayadqu6@destiny> References: <20180125180256.10844-5-bo.li.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180125180256.10844-5-bo.li.liu@oracle.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Jan 25, 2018 at 11:02:52AM -0700, Liu Bo wrote: > It's possible that btrfs_sync_log() bails out after one of the two > btrfs_write_marked_extents() which convert extent state's state bit into > EXTENT_NEED_WAIT from EXTENT_DIRTY/EXTENT_NEW, however only EXTENT_DIRTY > and EXTENT_NEW are searched by free_log_tree() so that those extent states > with EXTENT_NEED_WAIT lead to memory leak. > > cc: > Signed-off-by: Liu Bo Reviewed-by: Josef Bacik Thanks, Josef