From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/2] btrfs: add read_mirror_policy parameter devid
Date: Tue, 30 Jan 2018 14:30:20 +0800 [thread overview]
Message-ID: <20180130063020.14850-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20180130063020.14850-1-anand.jain@oracle.com>
Adds the mount option:
mount -o read_mirror_policy=<devid>
To set the devid of the device which should be used for read. That
means all the normal reads will go to that particular device only.
This also helps testing and gives a better control for the test
scripts including mount context reads.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/super.c | 21 +++++++++++++++++++++
fs/btrfs/volumes.c | 10 ++++++++++
fs/btrfs/volumes.h | 2 ++
3 files changed, 33 insertions(+)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index dfe6b3c67df3..d3aad8cccc7e 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -847,6 +847,27 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
BTRFS_READ_MIRROR_BY_PID;
break;
}
+
+ intarg = 0;
+ if (match_int(&args[0], &intarg) == 0) {
+ struct btrfs_device *device;
+
+ device = btrfs_find_device(info, intarg,
+ NULL, NULL);
+ if (!device) {
+ btrfs_err(info,
+ "read_mirror_policy: invalid devid %d",
+ intarg);
+ ret = -EINVAL;
+ goto out;
+ }
+ info->read_mirror_policy =
+ BTRFS_READ_MIRROR_BY_DEV;
+ set_bit(BTRFS_DEV_STATE_READ_MIRROR,
+ &device->dev_state);
+ break;
+ }
+
ret = -EINVAL;
goto out;
case Opt_err:
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 39ba59832f38..478623e6e074 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -5270,6 +5270,16 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info,
num = map->num_stripes;
switch(fs_info->read_mirror_policy) {
+ case BTRFS_READ_MIRROR_BY_DEV:
+ optimal = first;
+ if (test_bit(BTRFS_DEV_STATE_READ_MIRROR,
+ &map->stripes[optimal].dev->dev_state))
+ break;
+ if (test_bit(BTRFS_DEV_STATE_READ_MIRROR,
+ &map->stripes[++optimal].dev->dev_state))
+ break;
+ optimal = first;
+ break;
case BTRFS_READ_MIRROR_DEFAULT:
case BTRFS_READ_MIRROR_BY_PID:
default:
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index 78f35d299a61..7281f55dea05 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -50,6 +50,7 @@ struct btrfs_pending_bios {
enum btrfs_read_mirror_type {
BTRFS_READ_MIRROR_DEFAULT,
BTRFS_READ_MIRROR_BY_PID,
+ BTRFS_READ_MIRROR_BY_DEV,
};
#define BTRFS_DEV_STATE_WRITEABLE (0)
@@ -57,6 +58,7 @@ enum btrfs_read_mirror_type {
#define BTRFS_DEV_STATE_MISSING (2)
#define BTRFS_DEV_STATE_REPLACE_TGT (3)
#define BTRFS_DEV_STATE_FLUSH_SENT (4)
+#define BTRFS_DEV_STATE_READ_MIRROR (5)
struct btrfs_device {
struct list_head dev_list;
--
2.7.0
next prev parent reply other threads:[~2018-01-30 6:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 6:30 [PATCH 0/2] Policy to balance read across mirrored devices Anand Jain
2018-01-30 6:30 ` [PATCH 1/2] btrfs: add mount option read_mirror_policy Anand Jain
2018-01-31 8:06 ` Nikolay Borisov
2018-01-31 9:06 ` Anand Jain
2018-01-30 6:30 ` Anand Jain [this message]
2018-01-31 8:38 ` [PATCH 2/2] btrfs: add read_mirror_policy parameter devid Nikolay Borisov
2018-01-31 9:28 ` Anand Jain
2018-01-31 9:54 ` Nikolay Borisov
2018-01-31 13:38 ` Anand Jain
2018-01-31 13:42 ` Nikolay Borisov
2018-01-31 14:36 ` Anand Jain
2018-02-01 5:26 ` Edmund Nadolski
2018-02-01 8:12 ` Anand Jain
2018-02-01 23:46 ` Edmund Nadolski
2018-02-02 12:36 ` Austin S. Hemmelgarn
2018-02-05 7:21 ` Anand Jain
2018-01-31 7:51 ` [PATCH 0/2] Policy to balance read across mirrored devices Peter Becker
2018-01-31 9:01 ` Anand Jain
2018-01-31 10:47 ` Peter Becker
2018-01-31 14:26 ` Anand Jain
2018-01-31 14:52 ` Peter Becker
2018-01-31 16:11 ` Austin S. Hemmelgarn
2018-01-31 16:40 ` Peter Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130063020.14850-3-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).