From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: Add chunk allocation ENOSPC debug message for enospc_debug mount option
Date: Tue, 30 Jan 2018 14:48:40 +0100 [thread overview]
Message-ID: <20180130134840.GE19355@twin.jikos.cz> (raw)
In-Reply-To: <3e152104-2a67-5677-dea5-4863de26aa78@suse.com>
On Mon, Jan 22, 2018 at 10:11:44AM +0200, Nikolay Borisov wrote:
> > @@ -4731,6 +4740,12 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
> >
> > if (ndevs < devs_increment * sub_stripes || ndevs < devs_min) {
> > ret = -ENOSPC;
> > + if (btrfs_test_opt(info, ENOSPC_DEBUG)) {
> > + btrfs_debug(info,
> > + "%s: not enough devices with free space: have=%d minimal required=%d",
>
> nit: s/minimal/minimum
> But there is no point in resending just for that, I guess David could
> fix it while merging.
Yes, string updated and added to next, thanks.
prev parent reply other threads:[~2018-01-30 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 6:13 [PATCH] btrfs: Add chunk allocation ENOSPC debug message for enospc_debug mount option Qu Wenruo
2018-01-16 13:47 ` Nikolay Borisov
2018-01-17 0:52 ` Qu Wenruo
2018-01-17 16:13 ` Nikolay Borisov
2018-01-22 5:50 ` [PATCH v2] " Qu Wenruo
2018-01-22 8:11 ` Nikolay Borisov
2018-01-30 13:48 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130134840.GE19355@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).