From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: Ignore errors from btrfs_qgroup_trace_extent_post
Date: Tue, 30 Jan 2018 15:04:53 +0100 [thread overview]
Message-ID: <20180130140453.GF19355@twin.jikos.cz> (raw)
In-Reply-To: <3e753bcf-415e-ad94-ee5f-28cf1c9ca477@gmx.com>
On Mon, Jan 29, 2018 at 10:06:52PM +0800, Qu Wenruo wrote:
>
>
> On 2018年01月29日 21:53, Nikolay Borisov wrote:
> > Running generic/019 with qgroups on the scratch device enabled is
> > almost guaranteed to trigger the BUG_ON in btrfs_free_tree_block. It's
> > supposed to trigger only on -ENOMEM, in reality, however, it's possible
> > to get -EIO from btrfs_qgroup_trace_extent_post. This function just
> > finds the roots of the extent being tracked and sets the qrecord->old_roots
> > list. If this operation fails nothing critical happens except the
> > quota accounting can be considered wrong. In such case just set the
> > INCONSISTENT flag for the quota and print a warning, rather than
> > killing off the system. Additionally, it's possible to trigger a BUG_ON
> > in btrfs_truncate_inode_items as well.
> >
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
Added to next, thanks.
prev parent reply other threads:[~2018-01-30 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 7:44 [PATCH v2] btrfs: Gracefully handle errors in btrfs_qgroup_trace_extent_post Nikolay Borisov
2018-01-29 11:09 ` Qu Wenruo
2018-01-29 11:21 ` Nikolay Borisov
2018-01-29 11:57 ` Qu Wenruo
2018-01-29 13:44 ` Nikolay Borisov
2018-01-29 13:53 ` [PATCH v3] btrfs: Ignore errors from btrfs_qgroup_trace_extent_post Nikolay Borisov
2018-01-29 14:06 ` Qu Wenruo
2018-01-30 14:04 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130140453.GF19355@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).