linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz, quwenruo.btrfs@gmx.com
Subject: Re: [RFC PATCH v2 0/4] Add support for export testsuits
Date: Fri, 2 Feb 2018 19:47:11 +0100	[thread overview]
Message-ID: <20180202184711.GC18553@twin.jikos.cz> (raw)
In-Reply-To: <1517560445-5712-1-git-send-email-gujx@cn.fujitsu.com>

On Fri, Feb 02, 2018 at 04:34:01PM +0800, Gu Jinxiang wrote:
> Achieved:
> 1. export testsuit by:
>  $ make EXPORT=/where/you/want/to/generate/tests.tar.gz package
> relative path and absolute path both be ok.
> Besides tests itself, fssum and btrfs-corrupt-block will also be
> included in tests.tar.gz, since misc and fsck tests depend on
> btrfs-corrupt-block, and misc tests depend on fssum. 

My idea was:

$ make testuite

that will build all dependencies, ie. fssum and btrfs-corrupt-block, and
create btrfs-progs-tests.tar.gz in the current directory, ie. no need
for the EXPORT variable.

The tar command you used would add anything that's under tessts/ but we
don't need everything. So I'd expect there's a file that lists all files
and directories that we want in the testsuite tarball.

Some sort of identification should be put to the tarball, eg. what git
describe says and timestamp of generation.

> 2. after decompress tests.tar.gz, run test by:
>  $ TEST=`MASK` ./mkfs-tests.sh
> and, without MASK also be ok.
> replenish:
> The directory Structure after decompress tests.tar.gz is:
>  $ tar -xzvf ./tests.tar.gz
>  $ ls
>    tests fssum btrfs-corrupt-block

The structure could be reduced by one directory level if the contents of
tests is moved one directory up. That way all the test driver scritps
are in the same place as fssum and btrfs-corrupt-block. This would need
to be reflected in the test scripts.

      parent reply	other threads:[~2018-02-02 18:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02  8:34 [RFC PATCH v2 0/4] Add support for export testsuits Gu Jinxiang
2018-02-02  8:34 ` [RFC PATCH v2 1/4] btrfs-progs: Add package command for packaging tests Gu Jinxiang
2018-02-02  8:34 ` [RFC PATCH v2 2/4] btrfs-progs: Add EXEC represent path of executable file Gu Jinxiang
2018-02-02 18:07   ` David Sterba
2018-02-03  9:07     ` Gu, Jinxiang
2018-02-05 17:17       ` David Sterba
2018-02-02  8:34 ` [RFC PATCH v2 3/4] btrfs-progs: Modify rootdir files when use mkfs.btrfs Gu Jinxiang
2018-02-02 18:11   ` David Sterba
2018-02-02  8:34 ` [RFC PATCH v2 4/4] btrfs-progs: Add readme for export testsuits Gu Jinxiang
2018-02-02 10:41 ` [RFC PATCH v2 0/4] Add support " Nikolay Borisov
2018-02-02 10:59   ` Qu Wenruo
2018-02-02 18:47 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180202184711.GC18553@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=gujx@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).