From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: [PATCH 0/3] btrfs-progs: Split original mode check to its own
Date: Tue, 6 Feb 2018 15:02:20 +0800 [thread overview]
Message-ID: <20180206070223.28791-1-wqu@suse.com> (raw)
This time, there are 2 patches too large to reach mail list, so please
fetch the whole patchset from github as usual:
https://github.com/adam900710/btrfs-progs/tree/split_check_part2
The branch is based on devel branch, whose HEAD is:
commit 3aa1bbdd89ee9c9c48d260a6192fae08328f1b2f (david/devel)
Author: David Sterba <dsterba@suse.com>
Date: Sat Feb 3 01:15:42 2018 +0100
btrfs-progs: mkfs: fix build on musl
Another build failure on musl.
Issue: #90
Signed-off-by: David Sterba <dsterba@suse.com>
The first patch moves remaining common code to mode-common.c.
Things like transid fix, which is handled in read_tree_block(), get
moved to mode-common.c.
And commented added for exported functions.
The 2nd patch moves the original mode code to mode-original.c.
Unlike lowmem mode, original mode has more functions exported, as things
like bad items repair is integrated into the main funtion.
The last patch moves check/main.c back to cmds-check.c to keep
subcommand hierarchy.
With the split done, we now have a clear view about the check code size:
$ wc -l check/*.[ch] cmds-check.c | sort -h
67 check/mode-lowmem.h
137 check/mode-common.h
308 check/mode-original.h
661 cmds-check.c
2062 check/mode-common.c
4573 check/mode-lowmem.c
7577 check/mode-original.c
Qu Wenruo (3):
btrfs-progs: check: Move more shared codes to mode-common.c
btrfs-progs: Move the remaining original mode code to mode-original.c
btrfs-progs: Move check/main.c to cmds-check.c to maintain the
subcommand hierarchy
Makefile | 7 +-
check/mode-common.c | 1711 +++++++++
check/mode-common.h | 39 +-
check/{main.c => mode-original.c} | 6954 ++++++++++++-------------------------
check/mode-original.h | 32 +-
cmds-check.c | 661 ++++
6 files changed, 4742 insertions(+), 4662 deletions(-)
rename check/{main.c => mode-original.c} (76%)
create mode 100644 cmds-check.c
--
2.16.1
next reply other threads:[~2018-02-06 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 7:02 Qu Wenruo [this message]
2018-02-06 7:02 ` [PATCH 3/3] btrfs-progs: Move check/main.c to cmds-check.c to maintain the subcommand hierarchy Qu Wenruo
2018-03-09 16:56 ` [PATCH 0/3] btrfs-progs: Split original mode check to its own David Sterba
2018-03-10 4:46 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206070223.28791-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).