linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] btrfs-progs: Split original mode check to its own
@ 2018-02-06  7:02 Qu Wenruo
  2018-02-06  7:02 ` [PATCH 3/3] btrfs-progs: Move check/main.c to cmds-check.c to maintain the subcommand hierarchy Qu Wenruo
  2018-03-09 16:56 ` [PATCH 0/3] btrfs-progs: Split original mode check to its own David Sterba
  0 siblings, 2 replies; 5+ messages in thread
From: Qu Wenruo @ 2018-02-06  7:02 UTC (permalink / raw)
  To: linux-btrfs, dsterba

This time, there are 2 patches too large to reach mail list, so please
fetch the whole patchset from github as usual:
https://github.com/adam900710/btrfs-progs/tree/split_check_part2

The branch is based on devel branch, whose HEAD is:
commit 3aa1bbdd89ee9c9c48d260a6192fae08328f1b2f (david/devel)
Author: David Sterba <dsterba@suse.com>
Date:   Sat Feb 3 01:15:42 2018 +0100

    btrfs-progs: mkfs: fix build on musl
    
    Another build failure on musl.
    
    Issue: #90
    Signed-off-by: David Sterba <dsterba@suse.com>


The first patch moves remaining common code to mode-common.c.
Things like transid fix, which is handled in read_tree_block(), get
moved to mode-common.c.
And commented added for exported functions.

The 2nd patch moves the original mode code to mode-original.c.
Unlike lowmem mode, original mode has more functions exported, as things
like bad items repair is integrated into the main funtion.

The last patch moves check/main.c back to cmds-check.c to keep
subcommand hierarchy.

With the split done, we now have a clear view about the check code size:
$ wc -l check/*.[ch] cmds-check.c | sort -h
    67 check/mode-lowmem.h
   137 check/mode-common.h
   308 check/mode-original.h
   661 cmds-check.c
  2062 check/mode-common.c
  4573 check/mode-lowmem.c
  7577 check/mode-original.c

Qu Wenruo (3):
  btrfs-progs: check: Move more shared codes to mode-common.c
  btrfs-progs: Move the remaining original mode code to mode-original.c
  btrfs-progs: Move check/main.c to cmds-check.c to maintain the
    subcommand hierarchy

 Makefile                          |    7 +-
 check/mode-common.c               | 1711 +++++++++
 check/mode-common.h               |   39 +-
 check/{main.c => mode-original.c} | 6954 ++++++++++++-------------------------
 check/mode-original.h             |   32 +-
 cmds-check.c                      |  661 ++++
 6 files changed, 4742 insertions(+), 4662 deletions(-)
 rename check/{main.c => mode-original.c} (76%)
 create mode 100644 cmds-check.c

-- 
2.16.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 0/3] btrfs-progs: Split mode-original code
@ 2018-03-12  7:15 Qu Wenruo
  2018-03-12  7:15 ` [PATCH 3/3] btrfs-progs: Move check/main.c to cmds-check.c to maintain the subcommand hierarchy Qu Wenruo
  0 siblings, 1 reply; 5+ messages in thread
From: Qu Wenruo @ 2018-03-12  7:15 UTC (permalink / raw)
  To: linux-btrfs; +Cc: dsterba

This patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/split_check_for_david

This is the remaining part of the check code split.
After the code split, the old cmds-check.c will return to make every
subcommand have its own cmds-*.c.
And there will be check/mode-original.[ch] and check/mode-lowmem.[ch] to
indicates the supported check mode.

As usual, some patch would be quite big so it won't reach mail list.
Please check github for full change.

Qu Wenruo (3):
  btrfs-progs: check: Move more shared codes to mode-common.c
  btrfs-progs: Move the remaining original mode code to mode-original.c
  btrfs-progs: Move check/main.c to cmds-check.c to maintain the
    subcommand hierarchy

 Makefile                          |    7 +-
 btrfsck.h                         |    1 -
 check/mode-common.c               | 1724 +++++++++
 check/mode-common.h               |   38 +
 check/{main.c => mode-original.c} | 6906 ++++++++++++-------------------------
 check/mode-original.h             |   32 +-
 cmds-check.c                      |  661 ++++
 7 files changed, 4724 insertions(+), 4645 deletions(-)
 rename check/{main.c => mode-original.c} (76%)
 create mode 100644 cmds-check.c

-- 
2.16.2


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-12  7:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-06  7:02 [PATCH 0/3] btrfs-progs: Split original mode check to its own Qu Wenruo
2018-02-06  7:02 ` [PATCH 3/3] btrfs-progs: Move check/main.c to cmds-check.c to maintain the subcommand hierarchy Qu Wenruo
2018-03-09 16:56 ` [PATCH 0/3] btrfs-progs: Split original mode check to its own David Sterba
2018-03-10  4:46   ` Qu Wenruo
  -- strict thread matches above, loose matches on Subject: below --
2018-03-12  7:15 [PATCH 0/3] btrfs-progs: Split mode-original code Qu Wenruo
2018-03-12  7:15 ` [PATCH 3/3] btrfs-progs: Move check/main.c to cmds-check.c to maintain the subcommand hierarchy Qu Wenruo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).