From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:54609 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbeBFOq6 (ORCPT ); Tue, 6 Feb 2018 09:46:58 -0500 Date: Tue, 6 Feb 2018 15:44:42 +0100 From: David Sterba To: Colin King Cc: Chris Mason , Josef Bacik , David Sterba , Liu Bo , linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][btrfs-next] btrfs: remove redundant check on ret and goto Message-ID: <20180206144442.GA31890@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20180112165258.27431-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180112165258.27431-1-colin.king@canonical.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Jan 12, 2018 at 04:52:58PM +0000, Colin King wrote: > From: Colin Ian King > > The check for a non-zero ret is redundant as the goto will jump to > the very next statement anyway. Remove this extraneous code. > > Detected by CoverityScan, CID#1463784 ("Identical code for different > branches") > > Signed-off-by: Colin Ian King Added to next, thanks.