From: David Sterba <dsterba@suse.cz>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v4 2/3] btrfs-progs: introduce TEST_TOP for resources except binaries
Date: Wed, 7 Feb 2018 17:25:07 +0100 [thread overview]
Message-ID: <20180207162507.GC3003@twin.jikos.cz> (raw)
In-Reply-To: <1517895445-17767-3-git-send-email-gujx@cn.fujitsu.com>
On Tue, Feb 06, 2018 at 01:37:24PM +0800, Gu Jinxiang wrote:
> Use TEST_TOP for tests/common, Documentation, images, and internal
> binaries.
Well, the point of TEST_TOP was also to remove the /tests/ subdirectory
from the paths if it's inside git and to set it to the top directory
where the exported testsuite resides. I'm not sure if we should continue
this back-and-forth. The project idea was stated out tersly so the
implementation was left "as an exercise". The v4 is close to what I'd
liek to merge, so let's give it a v5 and if there will be only small
things to fix I'll update the patches at commit time.
next prev parent reply other threads:[~2018-02-07 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 5:37 [PATCH v4 0/3] Add support for export testsuits Gu Jinxiang
2018-02-06 5:37 ` [PATCH v4 1/3] btrfs-progs: Add make testsuite command for export tests Gu Jinxiang
2018-02-06 5:37 ` [PATCH v4 2/3] btrfs-progs: introduce TEST_TOP for resources except binaries Gu Jinxiang
2018-02-07 16:25 ` David Sterba [this message]
2018-02-06 5:37 ` [PATCH v4 3/3] btrfs-progs: Add readme for export testsuits Gu Jinxiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207162507.GC3003@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).