From: David Sterba <dsterba@suse.cz>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v5 0/3] Add support for export testsuits
Date: Thu, 8 Feb 2018 19:02:11 +0100 [thread overview]
Message-ID: <20180208180211.GE3003@twin.jikos.cz> (raw)
In-Reply-To: <1518071660-16878-1-git-send-email-gujx@cn.fujitsu.com>
On Thu, Feb 08, 2018 at 02:34:17PM +0800, Gu Jinxiang wrote:
> Achieved:
> 1. export testsuite by:
> $ make testsuite
> files list in testsuites-list will be added into tarball btrfs-progs-tests.tar.gz.
>
> 2. after decompress btrfs-progs-tests.tar.gz, run test by:
> $ TEST=`MASK` ./tests/mkfs-tests.sh
> and, without MASK also be ok.
> replenish:
> $ tar -xzvf ./btrfs-progs-tests.tar.gz
> $ ls
> btrfs-progs
> tests directory and other files is in btrfs-progs.
>
> Changelog:
> v5->v4: modify patch2.
> make TEST_TOP to represent tests directory.
> and introduce INTERNAL_BIN for internal binaries.
Patches 1 and 2 applied. I reworked most of 1, my idea of the end result
of the testsutie is different. In patch 2, I've added quotes to all
lines that changed the variables on 'source ..' line. In such cases
please also look at the resulting code and do not just mechanically
apply the suggestion to rename a variable. Patch 3 does not bring much
information so I did not apply it and wrote the section myself.
The project idea lacked details, as the cards on the github Projects
page are supposed to be short. Not all of the tasks there are simple, so
if you'd want to work on something found there and see that's not clear
what to do, it would be better to open an issue so I can fill in.
next prev parent reply other threads:[~2018-02-08 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:34 [PATCH v5 0/3] Add support for export testsuits Gu Jinxiang
2018-02-08 6:34 ` [PATCH v5 1/3] btrfs-progs: Add make testsuite command for export tests Gu Jinxiang
2018-02-08 6:34 ` [PATCH v5 2/3] btrfs-progs: introduce TEST_TOP and INTERNAL_BIN for tests directory and internal binaries Gu Jinxiang
2018-02-08 6:34 ` [PATCH v5 3/3] btrfs-progs: Add readme for export testsuits Gu Jinxiang
2018-02-08 18:02 ` David Sterba [this message]
2018-02-09 1:33 ` [PATCH v5 0/3] Add support " Gu, Jinxiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208180211.GE3003@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).