From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: manage metadata_ratio mount option as %u
Date: Tue, 13 Feb 2018 17:50:44 +0800 [thread overview]
Message-ID: <20180213095048.9550-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20180213095048.9550-1-anand.jain@oracle.com>
As -o metadata_ratio mount option is unsinged so manage it as %u for
token verifications, instead of %s.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/super.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index bf629c8a6a47..b925a649a01a 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -362,7 +362,7 @@ static const match_table_t tokens = {
{Opt_norecovery, "norecovery"},
{Opt_flushoncommit, "flushoncommit"},
{Opt_noflushoncommit, "noflushoncommit"},
- {Opt_ratio, "metadata_ratio=%d"},
+ {Opt_ratio, "metadata_ratio=%u"},
{Opt_discard, "discard"},
{Opt_nodiscard, "nodiscard"},
{Opt_space_cache, "space_cache"},
@@ -648,16 +648,11 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
break;
case Opt_ratio:
ret = match_int(&args[0], &intarg);
- if (ret) {
- goto out;
- } else if (intarg >= 0) {
- info->metadata_ratio = intarg;
- btrfs_info(info, "metadata ratio %d",
- info->metadata_ratio);
- } else {
- ret = -EINVAL;
+ if (ret)
goto out;
- }
+ info->metadata_ratio = intarg;
+ btrfs_info(info, "metadata ratio %u",
+ info->metadata_ratio);
break;
case Opt_discard:
btrfs_set_and_info(info, DISCARD,
@@ -1369,7 +1364,7 @@ static int btrfs_show_options(struct seq_file *seq, struct dentry *dentry)
info->check_integrity_print_mask);
#endif
if (info->metadata_ratio)
- seq_printf(seq, ",metadata_ratio=%d",
+ seq_printf(seq, ",metadata_ratio=%u",
info->metadata_ratio);
if (btrfs_test_opt(info, PANIC_ON_FATAL_ERROR))
seq_puts(seq, ",fatal_errors=panic");
--
2.7.0
next prev parent reply other threads:[~2018-02-13 9:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:50 [PATCH] btrfs: manage thread_pool mount option as %u Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage subvolid " Anand Jain
2018-02-13 16:10 ` David Sterba
2018-02-14 17:11 ` [PATCH v2] btrfs: verify subvolid mount parameter Anand Jain
2018-02-23 22:08 ` David Sterba
2018-02-14 17:15 ` [PATCH] btrfs: manage subvolid mount option as %u Anand Jain
2018-02-13 9:50 ` Anand Jain [this message]
2018-02-13 9:50 ` [PATCH] btrfs: manage check_int_print_mask " Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage commit " Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: add a comment to mark the deprecated mount option Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: fix bare unsigned declarations Anand Jain
2018-02-13 16:58 ` David Sterba
2018-02-14 17:13 ` [PATCH v2] " Anand Jain
2018-02-23 22:12 ` David Sterba
2018-02-26 8:46 ` [PATCH v3] " Anand Jain
2018-03-07 16:07 ` David Sterba
2018-02-13 14:26 ` [PATCH] btrfs: manage thread_pool mount option as %u Nikolay Borisov
2018-02-13 15:18 ` Anand Jain
2018-02-13 15:34 ` Nikolay Borisov
2018-02-13 15:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213095048.9550-3-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).