From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Move error handling of btrfs_start_dirty_block_groups closer to call site
Date: Wed, 14 Feb 2018 14:32:10 +0100 [thread overview]
Message-ID: <20180214133210.GE3003@twin.jikos.cz> (raw)
In-Reply-To: <1518168618-16708-1-git-send-email-nborisov@suse.com>
On Fri, Feb 09, 2018 at 11:30:18AM +0200, Nikolay Borisov wrote:
> Even though btrfs_start_dirty_block_groups fairly in the beginning of
> btrfs_commit_transaction outside of the critical section defined by the
> transaction states it can only be run by a single comitter. In other
> words it defines its own critical section thanks to the
> BTRFS_TRANS_DIRTY_BG run flag and ro_block_group_mutex. However, its
> error handling is outside of this critical section which is a bit
> counter-intuitive. So move the error handling righ after the function
> is executed and let the sole runner of dirty block groups handle the
> return value. no functional changes
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2018-02-14 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 9:30 [PATCH] btrfs: Move error handling of btrfs_start_dirty_block_groups closer to call site Nikolay Borisov
2018-02-14 13:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214133210.GE3003@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).