From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH] btrfs-progs: mkfs/rootdir: Fix memory leak in traverse_directory()
Date: Wed, 14 Feb 2018 17:34:26 +0100 [thread overview]
Message-ID: <20180214163426.GI3003@twin.jikos.cz> (raw)
In-Reply-To: <20180214075006.6576-1-wqu@suse.com>
On Wed, Feb 14, 2018 at 03:50:06PM +0800, Qu Wenruo wrote:
> The bug is exposed by mkfs test case 009, with D=asan.
>
> We are leaking memory of parent_dir_entry->path() which ,except the
> rootdir, is allocated by strdup().
>
> Before fixing it, unifiy the allocation of parent_dir_entry() to heap
> allocation.
>
> Then fix it by adding "free(parent_dir_entry->path);" in
> traverse_directory() and error handler.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Applied, thanks.
prev parent reply other threads:[~2018-02-14 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 7:50 [PATCH] btrfs-progs: mkfs/rootdir: Fix memory leak in traverse_directory() Qu Wenruo
2018-02-14 16:34 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214163426.GI3003@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).