* [PATCH] btrfs: remove unused function btrfs_async_submit_limit()
@ 2018-02-15 3:36 Anand Jain
2018-02-15 8:29 ` Nikolay Borisov
0 siblings, 1 reply; 3+ messages in thread
From: Anand Jain @ 2018-02-15 3:36 UTC (permalink / raw)
To: linux-btrfs
Commit [1] removed the need to use btrfs_async_submit_limit(), so
delete it.
[1]
commit 736cd52e0c720103f52ab9da47b6cc3af6b083f6
Btrfs: remove nr_async_submits and async_submit_draining
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/disk-io.c | 8 --------
fs/btrfs/disk-io.h | 1 -
2 files changed, 9 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index aca906971abe..c412ad1f103b 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -709,14 +709,6 @@ blk_status_t btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio,
return 0;
}
-unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info)
-{
- unsigned long limit = min_t(unsigned long,
- info->thread_pool_size,
- info->fs_devices->open_devices);
- return 256 * limit;
-}
-
static void run_one_async_start(struct btrfs_work *work)
{
struct async_submit_bio *async;
diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h
index 301151a50ac1..e2ac6a14150a 100644
--- a/fs/btrfs/disk-io.h
+++ b/fs/btrfs/disk-io.h
@@ -133,7 +133,6 @@ blk_status_t btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
u64 bio_offset, void *private_data,
extent_submit_bio_hook_t *submit_bio_start,
extent_submit_bio_hook_t *submit_bio_done);
-unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info);
int btrfs_write_tree_block(struct extent_buffer *buf);
void btrfs_wait_tree_block_writeback(struct extent_buffer *buf);
int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unused function btrfs_async_submit_limit()
2018-02-15 3:36 [PATCH] btrfs: remove unused function btrfs_async_submit_limit() Anand Jain
@ 2018-02-15 8:29 ` Nikolay Borisov
2018-02-19 15:01 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Borisov @ 2018-02-15 8:29 UTC (permalink / raw)
To: Anand Jain, linux-btrfs
On 15.02.2018 05:36, Anand Jain wrote:
> Commit [1] removed the need to use btrfs_async_submit_limit(), so
> delete it.
>
> [1]
> commit 736cd52e0c720103f52ab9da47b6cc3af6b083f6
> Btrfs: remove nr_async_submits and async_submit_draining
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/disk-io.c | 8 --------
> fs/btrfs/disk-io.h | 1 -
> 2 files changed, 9 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index aca906971abe..c412ad1f103b 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -709,14 +709,6 @@ blk_status_t btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio,
> return 0;
> }
>
> -unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info)
> -{
> - unsigned long limit = min_t(unsigned long,
> - info->thread_pool_size,
> - info->fs_devices->open_devices);
> - return 256 * limit;
> -}
> -
> static void run_one_async_start(struct btrfs_work *work)
> {
> struct async_submit_bio *async;
> diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h
> index 301151a50ac1..e2ac6a14150a 100644
> --- a/fs/btrfs/disk-io.h
> +++ b/fs/btrfs/disk-io.h
> @@ -133,7 +133,6 @@ blk_status_t btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
> u64 bio_offset, void *private_data,
> extent_submit_bio_hook_t *submit_bio_start,
> extent_submit_bio_hook_t *submit_bio_done);
> -unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info);
> int btrfs_write_tree_block(struct extent_buffer *buf);
> void btrfs_wait_tree_block_writeback(struct extent_buffer *buf);
> int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unused function btrfs_async_submit_limit()
2018-02-15 8:29 ` Nikolay Borisov
@ 2018-02-19 15:01 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-02-19 15:01 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: Anand Jain, linux-btrfs
On Thu, Feb 15, 2018 at 10:29:10AM +0200, Nikolay Borisov wrote:
> On 15.02.2018 05:36, Anand Jain wrote:
> > Commit [1] removed the need to use btrfs_async_submit_limit(), so
> > delete it.
> >
> > [1]
> > commit 736cd52e0c720103f52ab9da47b6cc3af6b083f6
> > Btrfs: remove nr_async_submits and async_submit_draining
> >
> > Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Added to next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-19 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 3:36 [PATCH] btrfs: remove unused function btrfs_async_submit_limit() Anand Jain
2018-02-15 8:29 ` Nikolay Borisov
2018-02-19 15:01 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).