* [PATCH 1/1] btrfs: remove assert in btrfs_init_dev_replace_tgtdev()
@ 2018-02-20 14:50 Anand Jain
2018-02-23 22:56 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Anand Jain @ 2018-02-20 14:50 UTC (permalink / raw)
To: linux-btrfs
In the same function we just ran btrfs_alloc_device() which means the
btrfs_device::resized_list is sure to be empty and we are protected
with the btrfs_fs_info::volume_mutex.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/volumes.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index d4a5f9126e7b..ac29ec0de984 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2655,7 +2655,6 @@ int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
device->total_bytes = btrfs_device_get_total_bytes(srcdev);
device->disk_total_bytes = btrfs_device_get_disk_total_bytes(srcdev);
device->bytes_used = btrfs_device_get_bytes_used(srcdev);
- ASSERT(list_empty(&srcdev->resized_list));
device->commit_total_bytes = srcdev->commit_total_bytes;
device->commit_bytes_used = device->bytes_used;
device->fs_info = fs_info;
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] btrfs: remove assert in btrfs_init_dev_replace_tgtdev()
2018-02-20 14:50 [PATCH 1/1] btrfs: remove assert in btrfs_init_dev_replace_tgtdev() Anand Jain
@ 2018-02-23 22:56 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-02-23 22:56 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs
On Tue, Feb 20, 2018 at 10:50:36PM +0800, Anand Jain wrote:
> In the same function we just ran btrfs_alloc_device() which means the
> btrfs_device::resized_list is sure to be empty and we are protected
> with the btrfs_fs_info::volume_mutex.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-20 14:50 [PATCH 1/1] btrfs: remove assert in btrfs_init_dev_replace_tgtdev() Anand Jain
2018-02-23 22:56 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).