From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz, peteryuchuang@gmail.com
Subject: [PATCH 0/4] Fix long standing -EOPNOTSUPP problem caused by
Date: Thu, 1 Mar 2018 10:47:43 +0800 [thread overview]
Message-ID: <20180301024747.26192-1-wqu@suse.com> (raw)
Kernel doesn't support dropping range inside inline extent, and prevents
such thing happening by limiting max inline extent size to
min(max_inline, sectorsize - 1) in cow_file_range_inline().
However btrfs-progs only inherit the BTRFS_MAX_INLINE_DATA_SIZE() macro,
which doesn't have sectorsize check.
And since btrfs-progs defaults to 16K nodesize, above macro allows large
inline extent over 15K size.
This leads to unexpected kernel behavior.
The bug exists from the very beginning of btrfs-convert, dating back to
2008 when btrfs-convert is first introduced.
Qu Wenruo (4):
btrfs-progs: Limit inline extent below page size
btrfs-progs: check/original mode: Check inline extent size
btrfs-progs: check/lowmem mode: Check inline extent size
btrfs-progs: test/convert: Add test case for invalid large inline data
extent
check/main.c | 4 ++++
check/mode-lowmem.c | 8 ++++++++
check/mode-original.h | 1 +
ctree.h | 11 +++++++++--
.../016-invalid-large-inline-extent/test.sh | 22 ++++++++++++++++++++++
5 files changed, 44 insertions(+), 2 deletions(-)
create mode 100755 tests/convert-tests/016-invalid-large-inline-extent/test.sh
--
2.16.2
next reply other threads:[~2018-03-01 2:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 2:47 Qu Wenruo [this message]
2018-03-01 2:47 ` [PATCH 1/4] btrfs-progs: Limit inline extent below page size Qu Wenruo
2018-03-01 17:47 ` Nikolay Borisov
2018-03-01 23:43 ` Qu Wenruo
2018-03-09 16:51 ` David Sterba
2018-03-01 2:47 ` [PATCH 2/4] btrfs-progs: check/original mode: Check inline extent size Qu Wenruo
2018-03-01 2:59 ` Su Yue
2018-03-01 2:47 ` [PATCH 3/4] btrfs-progs: check/lowmem " Qu Wenruo
2018-03-01 2:59 ` Su Yue
2018-03-01 2:47 ` [PATCH 4/4] btrfs-progs: test/convert: Add test case for invalid large inline data extent Qu Wenruo
2018-03-01 14:53 ` [PATCH 0/4] Fix long standing -EOPNOTSUPP problem caused by David Sterba
2018-03-02 5:25 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301024747.26192-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=peteryuchuang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).