From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH 1/5] btrfs: Parse options after node/sector size initialized
Date: Fri, 2 Mar 2018 13:22:50 +0800 [thread overview]
Message-ID: <20180302052254.7059-2-wqu@suse.com> (raw)
In-Reply-To: <20180302052254.7059-1-wqu@suse.com>
This provides the basis for later max_inline enhancement, which needs to
access fs_info->nodesize.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/disk-io.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index a8ecccfc36de..f7f985ed5af9 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2644,12 +2644,6 @@ int open_ctree(struct super_block *sb,
*/
fs_info->compress_type = BTRFS_COMPRESS_ZLIB;
- ret = btrfs_parse_options(fs_info, options, sb->s_flags);
- if (ret) {
- err = ret;
- goto fail_alloc;
- }
-
features = btrfs_super_incompat_flags(disk_super) &
~BTRFS_FEATURE_INCOMPAT_SUPP;
if (features) {
@@ -2692,6 +2686,13 @@ int open_ctree(struct super_block *sb,
fs_info->sectorsize = sectorsize;
fs_info->stripesize = stripesize;
+ /* Only parse options after node/sector size initialized */
+ ret = btrfs_parse_options(fs_info, options, sb->s_flags);
+ if (ret) {
+ err = ret;
+ goto fail_alloc;
+ }
+
/*
* mixed block groups end up with duplicate but slightly offset
* extent buffers for the same range. It leads to corruptions
--
2.16.2
next prev parent reply other threads:[~2018-03-02 5:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 5:22 [PATCH 0/5] max_inline related enhancement Qu Wenruo
2018-03-02 5:22 ` Qu Wenruo [this message]
2018-03-07 15:20 ` [PATCH 1/5] btrfs: Parse options after node/sector size initialized David Sterba
2018-03-02 5:22 ` [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size Qu Wenruo
2018-03-02 10:46 ` Filipe Manana
2018-03-02 10:54 ` Qu Wenruo
2018-03-02 11:00 ` Filipe Manana
2018-03-02 11:40 ` Qu Wenruo
2018-03-06 11:58 ` David Sterba
2018-03-06 12:08 ` Qu Wenruo
2018-03-02 5:22 ` [PATCH 3/5] btrfs: Embed sector size check into BTRFS_MAX_INLINE_DATA_SIZE() Qu Wenruo
2018-03-06 12:34 ` David Sterba
2018-03-02 5:22 ` [PATCH 4/5] btrfs: Unify inline extent creation condition for plain and compressed data Qu Wenruo
2018-03-02 5:22 ` [PATCH 5/5] btrfs: Show more accurate max_inline Qu Wenruo
2018-03-02 8:21 ` Misono, Tomohiro
2018-03-02 8:33 ` Nikolay Borisov
2018-03-02 8:34 ` Qu Wenruo
2018-03-02 8:37 ` Nikolay Borisov
2018-03-02 10:57 ` Qu Wenruo
2018-03-02 8:13 ` [PATCH 0/5] max_inline related enhancement Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302052254.7059-2-wqu@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).