* [PATCH] Btrfs: send: fix typo in TLV_PUT
@ 2018-03-03 1:05 Liu Bo
2018-03-05 20:32 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Liu Bo @ 2018-03-03 1:05 UTC (permalink / raw)
To: linux-btrfs
According to tlv_put()'s prototype, data and attrlen needs to be
exchanged in the macro, but seems all callers are already aware of
this misorder and are therefore not affected.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
fs/btrfs/send.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index f306c60..ee9ce67 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -611,9 +611,9 @@ static int tlv_put_btrfs_timespec(struct send_ctx *sctx, u16 attr,
}
-#define TLV_PUT(sctx, attrtype, attrlen, data) \
+#define TLV_PUT(sctx, attrtype, data, attrlen) \
do { \
- ret = tlv_put(sctx, attrtype, attrlen, data); \
+ ret = tlv_put(sctx, attrtype, data, attrlen); \
if (ret < 0) \
goto tlv_put_failure; \
} while (0)
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs: send: fix typo in TLV_PUT
2018-03-03 1:05 [PATCH] Btrfs: send: fix typo in TLV_PUT Liu Bo
@ 2018-03-05 20:32 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-03-05 20:32 UTC (permalink / raw)
To: Liu Bo; +Cc: linux-btrfs
On Fri, Mar 02, 2018 at 06:05:49PM -0700, Liu Bo wrote:
> According to tlv_put()'s prototype, data and attrlen needs to be
> exchanged in the macro, but seems all callers are already aware of
> this misorder and are therefore not affected.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03 1:05 [PATCH] Btrfs: send: fix typo in TLV_PUT Liu Bo
2018-03-05 20:32 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).