From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: replace: cache rbio when rebuild data on missing device
Date: Thu, 8 Mar 2018 22:40:01 -0700 [thread overview]
Message-ID: <20180309054001.GF26754@dhcp-10-211-47-181.usdhcp.oraclecorp.com> (raw)
In-Reply-To: <20180306112818.GN5942@twin.jikos.cz>
On Tue, Mar 06, 2018 at 12:28:18PM +0100, David Sterba wrote:
> On Fri, Mar 02, 2018 at 04:10:38PM -0700, Liu Bo wrote:
> > Rebuild on missing device is as same as recover, after it's done, rbio
> > has data which is consistent with on-disk data, so it can be cached to
> > avoid further reads.
>
> Please add a comment that describes why the READ and REBUILD can be
> merged together, it's not obvious from the code.
Will update it.
Thanks,
-liubo
next prev parent reply other threads:[~2018-03-09 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 23:10 [PATCH] Btrfs: replace: cache rbio when rebuild data on missing device Liu Bo
2018-03-06 11:28 ` David Sterba
2018-03-09 5:40 ` Liu Bo [this message]
2018-03-22 1:20 ` [PATCH V2] " Liu Bo
2018-03-22 14:13 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309054001.GF26754@dhcp-10-211-47-181.usdhcp.oraclecorp.com \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).