From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 1/4] btrfs-progs: mode-lowmem: Fix false alert about orphan inode
Date: Mon, 12 Mar 2018 19:19:22 +0100 [thread overview]
Message-ID: <20180312181921.GC32007@twin.jikos.cz> (raw)
In-Reply-To: <20180205064714.15659-1-wqu@suse.com>
On Mon, Feb 05, 2018 at 02:47:11PM +0800, Qu Wenruo wrote:
> Btrfs can delay inode deletion and in that case btrfs will unlink the
> victim inode from its parent dir, and insert a marker to info btrfs to
> delete it later.
>
> In that case, such victim inode will have nlinks == 0, but is still
> completely valid.
> Original mode won't report such problem, but lowmem mode doesn't check
> the ORPHAN_ITEM key for such inode, and can report false alert like:
> ------
> ERROR: root 257 INODE[28891726] is orphan item
> ------
>
> Fix such false alert by checking orphan item for inode whose nlink is 0.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
1-4 applied, thanks.
prev parent reply other threads:[~2018-03-12 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 6:47 [PATCH 1/4] btrfs-progs: mode-lowmem: Fix false alert about orphan inode Qu Wenruo
2018-02-05 6:47 ` [PATCH 2/4] btrfs-progs: fsck-tests: Add test case with valid " Qu Wenruo
2018-02-05 6:47 ` [PATCH 3/4] btrfs-progs: gitignore: Ignore *.restored test image Qu Wenruo
2018-02-05 6:47 ` [PATCH 4/4] btrfs-progs: gitignore: Ignore patches Qu Wenruo
2018-02-05 7:00 ` [PATCH 1/4] btrfs-progs: mode-lowmem: Fix false alert about orphan inode Su Yue
2018-03-12 18:09 ` David Sterba
2018-03-12 18:19 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312181921.GC32007@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).