From: David Sterba <dsterba@suse.cz>
To: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com, linux-btrfs@vger.kernel.org,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Josef Bacik <jbacik@fb.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] Btrfs: drop a VLA in btrfs_check_super_csum()
Date: Wed, 14 Mar 2018 16:42:48 +0100 [thread overview]
Message-ID: <20180314154248.GL32007@twin.jikos.cz> (raw)
In-Reply-To: <1520970622-19535-1-git-send-email-s.mesoraca16@gmail.com>
On Tue, Mar 13, 2018 at 08:50:22PM +0100, Salvatore Mesoraca wrote:
> Avoid a VLA[1] by using a real constant expression instead of a variable.
> The compiler should be able to optimize the original code and avoid using
> an actual VLA. Anyway this change is useful because it will avoid a false
> positive with -Wvla, it might also help the compiler generating better
> code.
>
> [1] https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
We already have a patch for that from a few days ago, but thanks anyway.
https://patchwork.kernel.org/patch/10277901/
next prev parent reply other threads:[~2018-03-14 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 19:50 [PATCH] Btrfs: drop a VLA in btrfs_check_super_csum() Salvatore Mesoraca
2018-03-14 15:42 ` David Sterba [this message]
2018-03-14 16:17 ` Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314154248.GL32007@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.mesoraca16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).