From: kbuild test robot <lkp@intel.com>
To: "Misono, Tomohiro" <misono.tomohiro@jp.fujitsu.com>
Cc: kbuild-all@01.org, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] btrfs: Add unprivileged ioctl which returns subvolume information
Date: Sun, 18 Mar 2018 12:16:12 +0800 [thread overview]
Message-ID: <201803181253.rfcRYpGc%fengguang.wu@intel.com> (raw)
In-Reply-To: <e786ad44-e2d9-d130-7c89-4173e10a007b@jp.fujitsu.com>
Hi Tomohiro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Misono-Tomohiro/btrfs-Add-three-new-unprivileged-ioctls-to-allow-normal-users-to-call-sub-list-show-etc/20180318-101013
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
fs/btrfs/ioctl.c:1561:9: sparse: incompatible types in comparison expression (different address spaces)
>> fs/btrfs/ioctl.c:2336:21: sparse: incorrect type in assignment (different address spaces) @@ expected struct btrfs_ioctl_get_subvol_info_args [noderef] <asn:1>*subvol_info @@ got sn:1>*subvol_info @@
fs/btrfs/ioctl.c:2336:21: expected struct btrfs_ioctl_get_subvol_info_args [noderef] <asn:1>*subvol_info
fs/btrfs/ioctl.c:2336:21: got void *
>> fs/btrfs/ioctl.c:2373:9: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *to @@ got unsigned char [noderef] <avoid *to @@
fs/btrfs/ioctl.c:2373:9: expected void *to
fs/btrfs/ioctl.c:2373:9: got unsigned char [noderef] <asn:1>*<noident>
fs/btrfs/ioctl.c:2374:9: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *to @@ got unsigned char [noderef] <avoid *to @@
fs/btrfs/ioctl.c:2374:9: expected void *to
fs/btrfs/ioctl.c:2374:9: got unsigned char [noderef] <asn:1>*<noident>
fs/btrfs/ioctl.c:2376:9: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *to @@ got unsigned char [noderef] <avoid *to @@
fs/btrfs/ioctl.c:2376:9: expected void *to
fs/btrfs/ioctl.c:2376:9: got unsigned char [noderef] <asn:1>*<noident>
>> fs/btrfs/ioctl.c:2416:39: sparse: incorrect type in argument 2 (different address spaces) @@ expected void *dst @@ got char [noderef] <avoid *dst @@
fs/btrfs/ioctl.c:2416:39: expected void *dst
fs/btrfs/ioctl.c:2416:39: got char [noderef] <asn:1>*<noident>
>> fs/btrfs/ioctl.c:2419:32: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *from @@ got struct btrfs_ioctl_get_subvol_info_args [nodervoid const *from @@
fs/btrfs/ioctl.c:2419:32: expected void const *from
fs/btrfs/ioctl.c:2419:32: got struct btrfs_ioctl_get_subvol_info_args [noderef] <asn:1>*subvol_info
>> fs/btrfs/ioctl.c:2423:16: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *<noident> @@ got struct btrfs_ioctl_get_subvol_info_args [nodervoid const *<noident> @@
fs/btrfs/ioctl.c:2423:16: expected void const *<noident>
fs/btrfs/ioctl.c:2423:16: got struct btrfs_ioctl_get_subvol_info_args [noderef] <asn:1>*subvol_info
fs/btrfs/ioctl.c:2917:24: sparse: incompatible types in comparison expression (different address spaces)
>> fs/btrfs/ioctl.c:2368:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2370:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2371:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2379:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2380:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2381:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2383:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2384:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2385:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2387:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2388:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2389:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2391:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2392:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2393:9: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2405:29: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2407:17: sparse: dereference of noderef expression
fs/btrfs/ioctl.c:2410:17: sparse: dereference of noderef expression
vim +2336 fs/btrfs/ioctl.c
2311
2312 /* Get the subvolume information in BTRFS_ROOT_ITEM and BTRFS_ROOT_BACKREF */
2313 static noinline int btrfs_ioctl_get_subvol_info(struct file *file,
2314 void __user *argp)
2315 {
2316 struct btrfs_ioctl_get_subvol_info_args __user *subvol_info;
2317 struct btrfs_root *root;
2318 struct btrfs_path *path;
2319 struct btrfs_key key;
2320
2321 struct btrfs_root_item root_item;
2322 struct btrfs_root_ref *rref;
2323 struct extent_buffer *l;
2324 int slot;
2325
2326 unsigned long item_off;
2327 unsigned long item_len;
2328
2329 struct inode *inode;
2330 int ret;
2331
2332 path = btrfs_alloc_path();
2333 if (!path)
2334 return -ENOMEM;
2335
> 2336 subvol_info = kzalloc(sizeof(*subvol_info), GFP_KERNEL);
2337 if (!subvol_info) {
2338 btrfs_free_path(path);
2339 return -ENOMEM;
2340 }
2341 inode = file_inode(file);
2342
2343 root = BTRFS_I(inode)->root->fs_info->tree_root;
2344 key.objectid = BTRFS_I(inode)->root->root_key.objectid;
2345 key.type = BTRFS_ROOT_ITEM_KEY;
2346 key.offset = 0;
2347 ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
2348 if (ret < 0) {
2349 goto out;
2350 } else if (ret > 0) {
2351 /* If the subvolume is a snapshot, offset is not zero */
2352 u64 objectid = key.objectid;
2353
2354 btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]);
2355 if (key.objectid != objectid ||
2356 key.type != BTRFS_ROOT_ITEM_KEY) {
2357 ret = -ENOENT;
2358 goto out;
2359 }
2360 }
2361
2362 l = path->nodes[0];
2363 slot = path->slots[0];
2364 item_off = btrfs_item_ptr_offset(l, slot);
2365 item_len = btrfs_item_size_nr(l, slot);
2366 read_extent_buffer(l, &root_item, item_off, item_len);
2367
> 2368 subvol_info->id = key.objectid;
2369
2370 subvol_info->generation = btrfs_root_generation(&root_item);
2371 subvol_info->flags = btrfs_root_flags(&root_item);
2372
> 2373 memcpy(subvol_info->uuid, root_item.uuid, BTRFS_UUID_SIZE);
> 2374 memcpy(subvol_info->parent_uuid, root_item.parent_uuid,
2375 BTRFS_UUID_SIZE);
> 2376 memcpy(subvol_info->received_uuid, root_item.received_uuid,
2377 BTRFS_UUID_SIZE);
2378
2379 subvol_info->ctransid = btrfs_root_ctransid(&root_item);
2380 subvol_info->ctime.sec = btrfs_stack_timespec_sec(&root_item.ctime);
2381 subvol_info->ctime.nsec = btrfs_stack_timespec_nsec(&root_item.ctime);
2382
2383 subvol_info->otransid = btrfs_root_otransid(&root_item);
2384 subvol_info->otime.sec = btrfs_stack_timespec_sec(&root_item.otime);
2385 subvol_info->otime.nsec = btrfs_stack_timespec_nsec(&root_item.otime);
2386
2387 subvol_info->stransid = btrfs_root_stransid(&root_item);
2388 subvol_info->stime.sec = btrfs_stack_timespec_sec(&root_item.stime);
2389 subvol_info->stime.nsec = btrfs_stack_timespec_nsec(&root_item.stime);
2390
2391 subvol_info->rtransid = btrfs_root_rtransid(&root_item);
2392 subvol_info->rtime.sec = btrfs_stack_timespec_sec(&root_item.rtime);
2393 subvol_info->rtime.nsec = btrfs_stack_timespec_nsec(&root_item.rtime);
2394
2395 btrfs_release_path(path);
2396 key.type = BTRFS_ROOT_BACKREF_KEY;
2397 key.offset = 0;
2398 ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
2399 if (ret < 0)
2400 goto out;
2401
2402 l = path->nodes[0];
2403 slot = path->slots[0];
2404 btrfs_item_key_to_cpu(l, &key, slot);
2405 if (key.objectid == subvol_info->id &&
2406 key.type == BTRFS_ROOT_BACKREF_KEY){
2407 subvol_info->parent_id = key.offset;
2408
2409 rref = btrfs_item_ptr(l, slot, struct btrfs_root_ref);
2410 subvol_info->dirid = btrfs_root_ref_dirid(l, rref);
2411
2412 item_off = btrfs_item_ptr_offset(l, slot)
2413 + sizeof(struct btrfs_root_ref);
2414 item_len = btrfs_item_size_nr(l, slot)
2415 - sizeof(struct btrfs_root_ref);
> 2416 read_extent_buffer(l, subvol_info->name, item_off, item_len);
2417 }
2418
> 2419 if (copy_to_user(argp, subvol_info, sizeof(*subvol_info)))
2420 ret = -EFAULT;
2421
2422 out:
> 2423 kzfree(subvol_info);
2424 btrfs_free_path(path);
2425 return ret;
2426 }
2427
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-03-18 4:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 8:09 [PATCH v2 0/3] btrfs: Add three new unprivileged ioctls to allow normal users to call "sub list/show" etc Misono, Tomohiro
2018-03-15 8:10 ` [PATCH v2 1/3] btrfs: Add unprivileged ioctl which returns subvolume information Misono, Tomohiro
2018-03-18 4:16 ` kbuild test robot [this message]
2018-03-15 8:11 ` [PATCH v2 2/3] btrfs: Add unprivileged ioctl which returns subvolume's ROOT_REF Misono, Tomohiro
2018-03-18 4:46 ` kbuild test robot
2018-03-15 8:11 ` [PATCH v2 3/3] btrfs: Add unprivileged version of ino_lookup ioctl Misono, Tomohiro
2018-03-18 5:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803181253.rfcRYpGc%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).