* [PATCH] btrfs-progs: convert/ext2: Remove check for ext2_ext_attr_entry->e_value_block
@ 2018-03-14 0:56 Qu Wenruo
2018-03-19 12:55 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2018-03-14 0:56 UTC (permalink / raw)
To: linux-btrfs; +Cc: dsterba
In latest e2fsprogs (1.44.0) definition of ext2_ext_attr_entry has
removed member e_value_block, as currently ext* doesn't support it set
anyway.
So remove such check so that we can pass compile.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Fast rolling distribution (Arch) catches this much faster.
---
convert/source-ext2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/convert/source-ext2.c b/convert/source-ext2.c
index b1492c78693d..070126ec38ec 100644
--- a/convert/source-ext2.c
+++ b/convert/source-ext2.c
@@ -422,8 +422,7 @@ static int ext2_xattr_check_entry(struct ext2_ext_attr_entry *entry,
{
size_t value_size = entry->e_value_size;
- if (entry->e_value_block != 0 || value_size > size ||
- entry->e_value_offs + value_size > size)
+ if (value_size > size || entry->e_value_offs + value_size > size)
return -EIO;
return 0;
}
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs-progs: convert/ext2: Remove check for ext2_ext_attr_entry->e_value_block
2018-03-14 0:56 [PATCH] btrfs-progs: convert/ext2: Remove check for ext2_ext_attr_entry->e_value_block Qu Wenruo
@ 2018-03-19 12:55 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-03-19 12:55 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs, dsterba
On Wed, Mar 14, 2018 at 08:56:57AM +0800, Qu Wenruo wrote:
> In latest e2fsprogs (1.44.0) definition of ext2_ext_attr_entry has
> removed member e_value_block, as currently ext* doesn't support it set
> anyway.
>
> So remove such check so that we can pass compile.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-14 0:56 [PATCH] btrfs-progs: convert/ext2: Remove check for ext2_ext_attr_entry->e_value_block Qu Wenruo
2018-03-19 12:55 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).