From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: Qu Wenruo <wqu@suse.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] btrfs-progs: extent buffer related refactor and cleanup
Date: Fri, 30 Mar 2018 15:01:46 +0800 [thread overview]
Message-ID: <20180330070146.GC548@fnst.localdomain> (raw)
In-Reply-To: <20180330054857.6106-1-wqu@suse.com>
On Fri, Mar 30, 2018 at 01:48:52PM +0800, Qu Wenruo wrote:
>The patchset can be fetched from github:
>https://github.com/adam900710/btrfs-progs/tree/eb_cleanup
>
>Just like kernel cleanup and refactors, this patchset will embed
>btrfs_fs_info structure into extent_buffer.
>
>And fixes several possible NULL pointer dereference (although not
>utilized in btrfs-progs yet).
>
>Changelog:
>v2:
> Embarrassingly, I forgot to install reiserfsprogs in my development
> machine, so the 3rd patch lacks one call site in
> convert/source-reiserfs.c.
>
>Qu Wenruo (5):
> btrfs-progs: extent_io: Fix NULL pointer dereference in
> free_extent_buffer_final()
> btrfs-progs: extent_io: Init eb->lru to avoid NULL pointer dereference
> btrfs-progs: extent_io: Refactor alloc_extent_buffer() to follow
> kernel parameters
> btrfs-progs: Unify btrfs_leaf_free_psace() parameter with kernel
> btrfs-progs: print-tree: Remove btrfs_root parameter
The patchset looks good to me.
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>
> btrfs-corrupt-block.c | 2 +-
> check/main.c | 2 +-
> check/mode-lowmem.c | 2 +-
> cmds-inspect-dump-tree.c | 31 ++++++++++------------
> convert/source-reiserfs.c | 3 +--
> ctree.c | 65 +++++++++++++++++++++++++----------------------
> ctree.h | 3 ++-
> disk-io.c | 3 +--
> extent-tree.c | 8 +++---
> extent_io.c | 17 ++++++++-----
> extent_io.h | 3 ++-
> print-tree.c | 20 ++++++++-------
> print-tree.h | 4 +--
> 13 files changed, 85 insertions(+), 78 deletions(-)
>
>--
>2.16.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Thanks,
Lu
next prev parent reply other threads:[~2018-03-30 7:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 5:48 [PATCH v2 0/5] btrfs-progs: extent buffer related refactor and cleanup Qu Wenruo
2018-03-30 5:48 ` [PATCH v2 1/5] btrfs-progs: extent_io: Fix NULL pointer dereference in free_extent_buffer_final() Qu Wenruo
2018-03-30 5:48 ` [PATCH v2 2/5] btrfs-progs: extent_io: Init eb->lru to avoid NULL pointer dereference Qu Wenruo
2018-03-30 5:48 ` [PATCH v2 3/5] btrfs-progs: extent_io: Refactor alloc_extent_buffer() to follow kernel parameters Qu Wenruo
2018-03-30 5:48 ` [PATCH v2 4/5] btrfs-progs: Unify btrfs_leaf_free_psace() parameter with kernel Qu Wenruo
2018-03-30 5:48 ` [PATCH v2 5/5] btrfs-progs: print-tree: Remove btrfs_root parameter Qu Wenruo
2018-03-30 7:01 ` Lu Fengqi [this message]
2018-04-09 14:54 ` [PATCH v2 0/5] btrfs-progs: extent buffer related refactor and cleanup David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330070146.GC548@fnst.localdomain \
--to=lufq.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).