From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs-progs: Enhance btrfs-image to handle missing device
Date: Fri, 30 Mar 2018 15:35:25 +0800 [thread overview]
Message-ID: <20180330073528.20650-1-wqu@suse.com> (raw)
Can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/btrfs_image_fix
Bug report:
https://github.com/kdave/btrfs-progs/issues/118
In short, the problem is caused by some old code (read_extent_data()
from ancient btrfs check code) and offset-by-one from btrfs-image.
Which makes btrfs-image can only read from the first stripe of RAID1.
And if device of the first stripe is missing, btrfs-image will fail.
Fix the problem and add test case for it.
Qu Wenruo (3):
btrfs-progs: disk-io: Fix read_extent_data() error handler for missing
device
btrfs-progs: convert: Fix offset-by-one error in read_data_extent()
btrfs-progs: tests/misc: Test if btrfs-image can handle RAID1 missing
device
disk-io.c | 6 ++-
image/main.c | 2 +-
tests/misc-tests/030-missing-device-image/test.sh | 57 +++++++++++++++++++++++
3 files changed, 62 insertions(+), 3 deletions(-)
create mode 100755 tests/misc-tests/030-missing-device-image/test.sh
--
2.16.3
next reply other threads:[~2018-03-30 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:35 Qu Wenruo [this message]
2018-03-30 7:35 ` [PATCH 1/3] btrfs-progs: disk-io: Fix read_extent_data() error handler for missing device Qu Wenruo
2018-03-30 7:35 ` [PATCH 2/3] btrfs-progs: convert: Fix offset-by-one error in read_data_extent() Qu Wenruo
2018-03-30 7:35 ` [PATCH 3/3] btrfs-progs: tests/misc: Test if btrfs-image can handle RAID1 missing device Qu Wenruo
2018-03-30 20:14 ` David Sterba
2018-03-30 20:15 ` [PATCH 0/3] btrfs-progs: Enhance btrfs-image to handle " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330073528.20650-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).