From: David Sterba <dsterba@suse.cz>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: modify path->reada in btrfs_shrink_device to READA_BACK
Date: Tue, 1 May 2018 15:44:04 +0200 [thread overview]
Message-ID: <20180501134404.GS21272@twin.jikos.cz> (raw)
In-Reply-To: <1524817327-32038-1-git-send-email-gujx@cn.fujitsu.com>
On Fri, Apr 27, 2018 at 04:22:07PM +0800, Gu Jinxiang wrote:
> In btrfs_shrink_device, before btrfs_search_slot, path->reada is
> set to READA_FORWARD. But I think READA_BACK is correct.
> Since,
> 1.key.offset is set to (u64)-1
> 2.After btrfs_search_slot, btrfs_previous_item is called.
> So, for readahead previous items, READA_BACK is correct one.
>
> Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
Added to next, thanks.
prev parent reply other threads:[~2018-05-01 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 8:22 [PATCH] btrfs: modify path->reada in btrfs_shrink_device to READA_BACK Gu Jinxiang
2018-04-27 8:28 ` Nikolay Borisov
2018-05-01 13:44 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501134404.GS21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox