From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: trace: Allow trace_qgroup_update_counters() to record old rfer/excl value
Date: Tue, 1 May 2018 16:56:04 +0200 [thread overview]
Message-ID: <20180501145604.GV21272@twin.jikos.cz> (raw)
In-Reply-To: <20180430070444.23837-1-wqu@suse.com>
On Mon, Apr 30, 2018 at 03:04:44PM +0800, Qu Wenruo wrote:
> Origin trace_qgroup_update_counters() only records qgroup id and its
> reference count change.
>
> It's good enough to debug qgroup accounting change, but when rescan race
> is involved, it's pretty hard to distinguish which modification belongs
> to which rescan.
>
> So add old_rfer and old_excl trace output to help distinguishing
> different rescan instance.
> (Different rescan instance should reset its qgroup->rfer to 0)
>
> For trace event parameter, it just changes from u64 qgroup_id to struct
> btrfs_qgroup *qgroup, so number of parameters is not changed at all.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2018-05-01 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 7:04 [PATCH] btrfs: trace: Allow trace_qgroup_update_counters() to record old rfer/excl value Qu Wenruo
2018-05-01 14:56 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501145604.GV21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox