From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix delalloc inodes leaking on btrfs unmount
Date: Tue, 8 May 2018 12:41:51 +0200 [thread overview]
Message-ID: <20180508104150.GH6649@suse.cz> (raw)
In-Reply-To: <366832e3-26c1-55a2-e1ab-be5efdb99b7c@suse.com>
On Tue, May 08, 2018 at 08:16:37AM +0300, Nikolay Borisov wrote:
> >> properly cleanup delalloc inodes and as a result cleans up the code a bit.
> >>
> >> I've given it a good bashing through xfstest (4 full xfstest cycles + 100
> >> iterations of generic/475 since it was hitting some early assertion failures,
> >> which are fixed in the final version) so am pretty confident in the change.
> >
> > One qemu testmachine complains.
> >
> > The branch was ext/nikbor/delalloc-invalidate in my github repo. Other
> > tests seem "fine", unlikely to be related to this patchset.
> >
> > The error here is a null pointer deref in end bio callback, which
> > matches a use-after-free scenario, so I think there's still something
> > left to fix.
> >
> > generic/335 [22:34:50]
>
> How easy is to repro this on this particular test? Like every other run
> or is it spurious?
It happened once, on first run of the testing setup, so I don't have
enough data to answer. I'll start another round and we'll see.
prev parent reply other threads:[~2018-05-08 10:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 9:21 [PATCH 0/5] Fix delalloc inodes leaking on btrfs unmount Nikolay Borisov
2018-04-27 9:21 ` [PATCH 1/5] btrfs: Unexport btrfs_alloc_delalloc_work Nikolay Borisov
2018-04-27 9:21 ` [PATCH 2/5] btrfs: Split btrfs_del_delalloc_inode into 2 functions Nikolay Borisov
2018-05-11 5:44 ` Anand Jain
2018-05-11 8:39 ` Nikolay Borisov
2018-05-16 15:27 ` David Sterba
2018-04-27 9:21 ` [PATCH 3/5] btrfs: Add assert in __btrfs_del_delalloc_inode Nikolay Borisov
2018-04-27 9:21 ` [PATCH 4/5] btrfs: Fix delalloc inodes invalidation during transaction abort Nikolay Borisov
2018-05-10 15:35 ` David Sterba
2018-04-27 9:21 ` [PATCH 5/5] btrfs: Unexport and rename btrfs_invalidate_inodes Nikolay Borisov
2018-04-27 11:36 ` [PATCH v2] " Nikolay Borisov
2018-04-28 16:33 ` kbuild test robot
2018-04-28 16:44 ` kbuild test robot
2018-04-28 18:04 ` kbuild test robot
2018-05-11 5:38 ` Anand Jain
2018-05-01 14:02 ` [PATCH 0/5] Fix delalloc inodes leaking on btrfs unmount David Sterba
2018-05-16 15:36 ` David Sterba
2018-05-07 22:58 ` David Sterba
2018-05-08 5:16 ` Nikolay Borisov
2018-05-08 10:41 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508104150.GH6649@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).