From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: check: Make btrfs check return error for qgroup mismatch
Date: Tue, 8 May 2018 19:45:13 +0200 [thread overview]
Message-ID: <20180508174513.GO6649@twin.jikos.cz> (raw)
In-Reply-To: <20180430061700.18498-1-wqu@suse.com>
On Mon, Apr 30, 2018 at 02:16:59PM +0800, Qu Wenruo wrote:
> Current btrfs-check will check qgroup consistency, but even when it
> finds something wrong, the return value is still 0.
>
> Fix it by allowing report_qgroups() to return int to indicate qgroup
> mismatch, and also add extra logical to return no error if qgroup repair
> is successful.
>
> Without this patch, fstests can't detect qgroup corruption by its fsck
> alone.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Applied, thanks. Please send the 0/N (cover letter) mail even for
2-patch series.
next prev parent reply other threads:[~2018-05-08 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 6:16 [PATCH 1/2] btrfs-progs: check: Make btrfs check return error for qgroup mismatch Qu Wenruo
2018-04-30 6:17 ` [PATCH 2/2] btrfs-progs: fsck-tests: Add test case to ensure btrfs check return error for corrupted qgroups Qu Wenruo
2018-05-08 17:45 ` David Sterba [this message]
2018-05-10 1:43 ` [PATCH 1/2] btrfs-progs: check: Make btrfs check return error for qgroup mismatch Qu Wenruo
2018-05-10 11:45 ` David Sterba
2018-05-10 12:17 ` Qu Wenruo
-- strict thread matches above, loose matches on Subject: below --
2018-04-30 6:28 Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508174513.GO6649@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox