From: Omar Sandoval <osandov@osandov.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH 06/10] Btrfs: don't return ino if inode item removal fails
Date: Thu, 10 May 2018 14:44:39 -0700 [thread overview]
Message-ID: <20180510214439.GC820@vader> (raw)
In-Reply-To: <995eb7ab-aa58-63ea-61d8-2fbcbbe767ac@suse.com>
On Thu, May 10, 2018 at 11:29:18AM +0300, Nikolay Borisov wrote:
>
>
> On 10.05.2018 09:21, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > In btrfs_evict_inode(), if btrfs_truncate_inode_items() fails, the inode
> > item will still be in the tree but we still return the ino to the ino
> > cache. That will blow up later when someone tries to allocate that ino,
> > so don't return it to the cache.
>
> Make the subject a bit more expicit:
>
> "Don't return ino to ino cache if inode item removal fails"
Good point, updated. Thanks!
next prev parent reply other threads:[~2018-05-10 21:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 6:21 [PATCH 00/10] Btrfs: orphan and truncate fixes Omar Sandoval
2018-05-10 6:21 ` [PATCH 01/10] Btrfs: remove stale comment referencing vmtruncate() Omar Sandoval
2018-05-10 6:21 ` [PATCH 02/10] Btrfs: fix error handling in btrfs_truncate_inode_items() Omar Sandoval
2018-05-10 8:09 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 03/10] Btrfs: don't BUG_ON() " Omar Sandoval
2018-05-10 8:10 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 04/10] Btrfs: stop creating orphan items for truncate Omar Sandoval
2018-05-10 6:21 ` [PATCH 05/10] Btrfs: don't release reserve or decrement orphan count if orphan item already existed Omar Sandoval
2018-05-10 8:23 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 06/10] Btrfs: don't return ino if inode item removal fails Omar Sandoval
2018-05-10 8:29 ` Nikolay Borisov
2018-05-10 21:44 ` Omar Sandoval [this message]
2018-05-10 6:21 ` [PATCH 07/10] Btrfs: refactor btrfs_evict_inode() reserve refill dance Omar Sandoval
2018-05-10 8:35 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 08/10] Btrfs: fix ENOSPC caused by orphan items reservations Omar Sandoval
2018-05-10 8:50 ` Nikolay Borisov
2018-05-10 23:25 ` Omar Sandoval
2018-05-10 6:21 ` [PATCH 09/10] Btrfs: get rid of unused orphan infrastructure Omar Sandoval
2018-05-10 6:21 ` [PATCH 10/10] Btrfs: reserve space for O_TMPFILE orphan item deletion Omar Sandoval
2018-05-10 15:25 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510214439.GC820@vader \
--to=osandov@osandov.com \
--cc=clm@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).