From: Roman Mamedov <rm@romanrm.net>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: inode: Don't compress if NODATASUM or NODATACOW set
Date: Mon, 14 May 2018 13:20:04 +0500 [thread overview]
Message-ID: <20180514132004.3afec300@natsu> (raw)
In-Reply-To: <90871596-c030-930b-57ad-7db63b4f579d@suse.com>
On Mon, 14 May 2018 11:10:34 +0300
Nikolay Borisov <nborisov@suse.com> wrote:
> But if we have mounted the fs with FORCE_COMPRESS shouldn't we disregard
> the inode flags, presumably the admin knows what he is doing?
Please don't. Personally I always assumed chattr +C would prevent both CoW and
compression, and used that as a way to override volume-wide compress-force for
a particular folder. Now that it turns out this wasn't working, the patch
would fix it to behave in line with prior expectations.
--
With respect,
Roman
next prev parent reply other threads:[~2018-05-14 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 7:02 [PATCH] btrfs: inode: Don't compress if NODATASUM or NODATACOW set Qu Wenruo
2018-05-14 8:10 ` Nikolay Borisov
2018-05-14 8:20 ` Roman Mamedov [this message]
2018-05-14 8:36 ` Nikolay Borisov
2018-05-14 9:31 ` james harvey
2018-05-14 9:39 ` Roman Mamedov
2018-05-14 9:46 ` Nikolay Borisov
2018-05-14 16:49 ` David Sterba
2018-05-14 9:30 ` james harvey
2018-05-14 10:35 ` Qu Wenruo
2018-05-14 22:24 ` james harvey
2018-05-15 0:15 ` james harvey
2018-05-14 8:24 ` Qu Wenruo
2018-05-14 16:52 ` David Sterba
2018-05-14 20:46 ` Timofey Titovets
2018-05-15 18:18 ` David Sterba
2018-05-14 22:29 ` james harvey
2018-05-15 1:35 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514132004.3afec300@natsu \
--to=rm@romanrm.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).