* [PATCH] btrfs: fix describe_relocation string pointer
@ 2018-05-17 13:25 Anand Jain
2018-05-18 17:02 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Anand Jain @ 2018-05-17 13:25 UTC (permalink / raw)
To: linux-btrfs
Looks like the original idea was to print the hex of the flags which
is not coded with their flag name. So use the current buf pointer bp
instead of buf.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/relocation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 74656d79e511..879b76fa881a 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -4344,7 +4344,7 @@ static void describe_relocation(struct btrfs_fs_info *fs_info,
DESCRIBE_FLAG(RAID5, "raid5");
DESCRIBE_FLAG(RAID6, "raid6");
if (flags)
- snprintf(buf, buf - bp + sizeof(buf), "|0x%llx", flags);
+ snprintf(bp, buf - bp + sizeof(buf), "|0x%llx", flags);
#undef DESCRIBE_FLAG
}
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: fix describe_relocation string pointer
2018-05-17 13:25 [PATCH] btrfs: fix describe_relocation string pointer Anand Jain
@ 2018-05-18 17:02 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-05-18 17:02 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs
On Thu, May 17, 2018 at 09:25:12PM +0800, Anand Jain wrote:
> Looks like the original idea was to print the hex of the flags which
> is not coded with their flag name. So use the current buf pointer bp
> instead of buf.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/relocation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
> index 74656d79e511..879b76fa881a 100644
> --- a/fs/btrfs/relocation.c
> +++ b/fs/btrfs/relocation.c
> @@ -4344,7 +4344,7 @@ static void describe_relocation(struct btrfs_fs_info *fs_info,
> DESCRIBE_FLAG(RAID5, "raid5");
> DESCRIBE_FLAG(RAID6, "raid6");
> if (flags)
> - snprintf(buf, buf - bp + sizeof(buf), "|0x%llx", flags);
> + snprintf(bp, buf - bp + sizeof(buf), "|0x%llx", flags);
Good catch.
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-18 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 13:25 [PATCH] btrfs: fix describe_relocation string pointer Anand Jain
2018-05-18 17:02 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).