From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <dchinner@redhat.com>,
darrick.wong@oracle.com, tytso@mit.edu,
linux-btrfs@vger.kernel.org, clm@fb.com, jbacik@fb.com,
viro@zeniv.linux.org.uk, peterz@infradead.org
Subject: Re: [PATCH 01/10] mm: pagecache add lock
Date: Fri, 18 May 2018 08:53:30 -0700 [thread overview]
Message-ID: <20180518155330.GA16931@infradead.org> (raw)
In-Reply-To: <20180518131305.GA6361@bombadil.infradead.org>
On Fri, May 18, 2018 at 06:13:06AM -0700, Matthew Wilcox wrote:
> > Historically, the only problematic case has been direct IO, and people
> > have been willing to say "well, if you mix buffered and direct IO you
> > get what you deserve", and that's probably not unreasonable. But now we
> > have fallocate insert range and collapse range, and those are broken in
> > ways I frankly don't want to think about if they can't ensure consistency
> > with the page cache.
>
> ext4 manages collapse-vs-pagefault with the ext4-specific i_mmap_sem.
> You may get pushback on the grounds that this ought to be a
> filesystem-specific lock rather than one embedded in the generic inode.
Honestly I think this probably should be in the core. But IFF we move
it to the core the existing users of per-fs locks need to be moved
over first. E.g. XFS as the very first one, and at least ext4 and f2fs
that copied the approach, and probably more if you audit deep enough.
next parent reply other threads:[~2018-05-18 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180518074918.13816-1-kent.overstreet@gmail.com>
[not found] ` <20180518074918.13816-3-kent.overstreet@gmail.com>
[not found] ` <20180518131305.GA6361@bombadil.infradead.org>
2018-05-18 15:53 ` Christoph Hellwig [this message]
2018-05-20 22:45 ` [PATCH 01/10] mm: pagecache add lock Kent Overstreet
2018-05-23 15:22 ` Christoph Hellwig
2018-05-23 17:12 ` Kent Overstreet
[not found] ` <20180518174549.GD31737@kmo-pixel>
2018-05-23 23:55 ` Notes on locking for pagacache consistency (was: [PATCH 01/10] mm: pagecache add lock) Kent Overstreet
[not found] ` <20180518074918.13816-21-kent.overstreet@gmail.com>
[not found] ` <905DA1CC-63F8-4020-A1D7-1F59ABDF3448@dilger.ca>
[not found] ` <20180518191040.GG31737@kmo-pixel>
2018-05-18 20:54 ` [PATCH 10/10] Dynamic fault injection Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518155330.GA16931@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=jbacik@fb.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).