From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
David Sterba <dsterba@suse.com>,
Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
Subject: Re: [PATCH] Btrfs: allow empty subvol= again
Date: Tue, 22 May 2018 12:50:14 +0200 [thread overview]
Message-ID: <20180522105014.GC6649@twin.jikos.cz> (raw)
In-Reply-To: <20180522001706.GD14774@vader>
> > This is silly but IMO it's a regression. If you agree, this should
> > probably go to 4.17 + stable. I'll submit an xfstests test shortly.
>
> Update, we fixed the userspace bug now so I'd be fine if we dropped this
> patch. I guess there's still a possibility that there are other users
> that hit this, so I'll leave it up to you, Dave, whether it's important
> enough to care.
The documentation does not say anything about the empty value of the
path, it's subvol=path, so I'm not sure if empty string is normally
considered a valid path.
I'll add the patch and update documentation, as it's a small issue, but
not really an urgent fix for 4.17. It also has a simple fix, to use / or
"." .
prev parent reply other threads:[~2018-05-22 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 0:07 [PATCH] Btrfs: allow empty subvol= again Omar Sandoval
2018-05-22 0:17 ` Omar Sandoval
2018-05-22 10:50 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522105014.GC6649@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).