Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH REBASED 0/2] btrfs: Delay block group auto removal to avoid interfering qgroups
Date: Wed, 30 May 2018 12:40:21 +0800	[thread overview]
Message-ID: <20180530044023.9192-1-wqu@suse.com> (raw)

The patchset can be fetched from github:
https://github.com/adam900710/linux/tree/delayed_bg_removal

It's based on David's misc-next branch, HEAD is:
commit c77a75861d82a497bd1a26054588cd9af59eb5db (david/misc-next)
Author: Ethan Lien <ethanlien@synology.com>
Date:   Mon May 28 13:48:20 2018 +0800

    btrfs: balance dirty metadata pages in btrfs_finish_ordered_io


This bug is reported from SUSE openQA, although it's pretty hard to hit
in real world (even real world VM), it's believed block group auto
removal (anyway, there isn't much thing can remove a chunk mapping in
btrfs) could interfere with qgroup's search on commit root.

Full details can be found in the 2rd patch.

The patchset uses 1 submitted cleanup/refactor patches as basis, and the
2nd patch will ensure unused block group will only be deleted after
current transaction is done.


Qu Wenruo (2):
  btrfs: Use btrfs_mark_bg_unused() to replace open code
  btrfs: Delayed empty block group auto removal to next transaction

 fs/btrfs/ctree.h       |  2 ++
 fs/btrfs/extent-tree.c | 62 +++++++++++++++++++++++++++++-------------
 fs/btrfs/scrub.c       |  9 +-----
 fs/btrfs/transaction.c |  7 +++++
 fs/btrfs/transaction.h | 10 +++++++
 5 files changed, 63 insertions(+), 27 deletions(-)

-- 
2.17.0


             reply	other threads:[~2018-05-30  4:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  4:40 Qu Wenruo [this message]
2018-05-30  4:40 ` [PATCH REBASED 1/2] btrfs: Use btrfs_mark_bg_unused() to replace open code Qu Wenruo
2018-05-30  6:50   ` Nikolay Borisov
2018-05-30  4:40 ` [PATCH REBASED 2/2] btrfs: Delayed empty block group auto removal to next transaction Qu Wenruo
2018-05-30  7:01   ` Nikolay Borisov
2018-05-30  7:14     ` Qu Wenruo
2018-06-13  7:23 ` [PATCH REBASED 0/2] btrfs: Delay block group auto removal to avoid interfering qgroups Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530044023.9192-1-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox