From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org, robbieko@synology.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix physical offset reported by fiemap for inline extents
Date: Tue, 19 Jun 2018 19:53:19 +0200 [thread overview]
Message-ID: <20180619175319.GU24375@twin.jikos.cz> (raw)
In-Reply-To: <20180619113142.9020-1-fdmanana@kernel.org>
On Tue, Jun 19, 2018 at 12:31:42PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> So fix this by ensuring the physical offset is always set to 0 when we
> are processing an inline extent.
>
> Fixes: 9d311e11fc1f ("Btrfs: fiemap: pass correct bytenr when fm_extent_count is zero")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Added to 4.18 queue, thanks.
This is a fix for a patch that was in for-next for a few weeks but the
bug was discovered only after the patch got merged to master. I wonder
if there's something to be improved in the patch flow.
I think it should take less time to catch bugs while the patches are
unmerged, either in the mailinglist or in the development branches.
Post-merge fixes will happen of course, but in this particular case it
looks like something that slipped too easily. I did the "fallback"
review and checked that tests regarding fiemap pass, the occasional
failure you mention has not happened on any of my testing setups.
There's another patch for fiemap that seems to have bigger impact and
for that reason I have postponed merging it to 4.18 unlike the first
one, but now I think this requires a testcase.
https://patchwork.kernel.org/patch/10383491/
The patch will be in for-next topic branch until then.
next prev parent reply other threads:[~2018-06-19 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 11:31 [PATCH] Btrfs: fix physical offset reported by fiemap for inline extents fdmanana
2018-06-19 17:53 ` David Sterba [this message]
2018-06-20 2:55 ` robbieko
2018-06-20 9:02 ` Filipe Manana
2018-06-20 9:02 ` [PATCH v2] " fdmanana
2018-06-25 9:36 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619175319.GU24375@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=robbieko@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox