From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: dsterba@suse.cz, Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>,
linux-btrfs@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH] btrfs: Use iocb to derive pos instead of passing a separate parameter
Date: Mon, 25 Jun 2018 13:06:32 -0500 [thread overview]
Message-ID: <20180625180632.aexsmtpfksfyn3hr@merlin> (raw)
In-Reply-To: <20180625162037.GG27958@twin.jikos.cz>
On 06-25 18:20, David Sterba wrote:
> On Mon, Jun 25, 2018 at 01:58:58PM +0900, Misono Tomohiro wrote:
> > So, this is the updated version of https://patchwork.kernel.org/patch/10063039/
> >
> > This time xfstest is ok and
> > Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Yes, thats right.
>
> Your comment about invalidate_mapping_pages is also ok, right? As
> filemap_fdatawait_range and invalidate_mapping_pages use the same
> start/end of the range.
I did not mess around with other functions which are affected by
iocb->ki_pos (as opposed to local pos). So, this should be safe with
respect to invalidate_mapping_pages().
--
Goldwyn
next prev parent reply other threads:[~2018-06-25 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 17:39 [PATCH] btrfs: Use iocb to derive pos instead of passing a separate parameter Goldwyn Rodrigues
2018-06-25 4:58 ` Misono Tomohiro
2018-06-25 16:20 ` David Sterba
2018-06-25 18:06 ` Goldwyn Rodrigues [this message]
2018-06-26 0:50 ` Misono Tomohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625180632.aexsmtpfksfyn3hr@merlin \
--to=rgoldwyn@suse.de \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=rgoldwyn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox