linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chengguang Xu <cgxu519@gmx.com>
To: clm@fb.com, jbacik@fb.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH v4 5/5] btrfs: remove unnecessary bracket in btrfs_get_acl()
Date: Wed, 27 Jun 2018 12:16:38 +0800	[thread overview]
Message-ID: <20180627041638.13210-6-cgxu519@gmx.com> (raw)
In-Reply-To: <20180627041638.13210-1-cgxu519@gmx.com>

It's only coding style fix not functinal change.
When if/else has only one statement then the bracket
is not needed.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
---
v4:
- Split patch to series.

v3:
- Fix some toher bad practices.
- Add more information to commit log.

v2:
- Avoid errno overriding instead of print error message in error case.
- Chagne commit log for better understanding.

 fs/btrfs/acl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 7d673ec9e54a..3b66c957ea6f 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -40,13 +40,12 @@ struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
 			return ERR_PTR(-ENOMEM);
 		size = btrfs_getxattr(inode, name, value, size);
 	}
-	if (size > 0) {
+	if (size > 0)
 		acl = posix_acl_from_xattr(&init_user_ns, value, size);
-	} else if (size == -ENODATA || size == 0) {
+	else if (size == -ENODATA || size == 0)
 		acl = NULL;
-	} else {
+	else
 		acl = ERR_PTR(size);
-	}
 	kfree(value);
 
 	return acl;
-- 
2.17.1


  parent reply	other threads:[~2018-06-27  4:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  4:16 [PATCH v4 0/5] code cleanups for btrfs_get_acl() Chengguang Xu
2018-06-27  4:16 ` [PATCH v4 1/5] btrfs: return error instead of crash when detecting unexpected type in btrfs_get_acl() Chengguang Xu
2018-06-27  4:16 ` [PATCH v4 2/5] btrfs: replace empty string with NULL when getting attribute length " Chengguang Xu
2018-06-27  4:16 ` [PATCH v4 3/5] btrfs: remove unnecessary -ERANGE check " Chengguang Xu
2018-06-27  4:16 ` [PATCH v4 4/5] btrfs: avoid error code overriding " Chengguang Xu
2018-06-27  4:16 ` Chengguang Xu [this message]
2018-06-27  7:21 ` [PATCH v4 0/5] code cleanups for btrfs_get_acl() David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627041638.13210-6-cgxu519@gmx.com \
    --to=cgxu519@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).