From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: check: Fix wrong root parameter of btrfs_next_leaf call
Date: Tue, 3 Jul 2018 00:19:02 +0200 [thread overview]
Message-ID: <20180702221902.GF3126@twin.jikos.cz> (raw)
In-Reply-To: <1529320239-23033-1-git-send-email-nborisov@suse.com>
On Mon, Jun 18, 2018 at 02:10:39PM +0300, Nikolay Borisov wrote:
> The first thing that check_chunks_and_extents does is to iterate all
> the root items in the root tree and link them to either the "normal_list"
> or "dropping_trees" list. If a leaf has to be crossed during this
> operation btrfs_next_leaf is called to do that. However, currently it's
> called with a wrong argument for its 'root' parameter. Since we are
> iterating the root tree the passed root should be fs_info->tree_rot,
> whereas right now we are passing the local variable 'root' which is
> assigned to the fs_tree. As it stands, this bug is actually benign since
> the passed root is only passed to reada_for_search, where it's used to
> reference the fs_info. Nevertheless the code is wrong and at the very least
> misleading, so fix it by passing the correct root.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Applied, thanks.
prev parent reply other threads:[~2018-07-02 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 11:10 [PATCH] btrfs-progs: check: Fix wrong root parameter of btrfs_next_leaf call Nikolay Borisov
2018-06-19 1:23 ` Su Yue
2018-07-02 22:19 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702221902.GF3126@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox