From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org, wqu@suse.com,
misono.tomohiro@jp.fujitsu.com
Subject: Re: [PATCH v2] btrfs: qgroups: Move transaction management inside btrfs_quota_enable/disable
Date: Thu, 5 Jul 2018 16:29:29 +0200 [thread overview]
Message-ID: <20180705142929.GF3126@twin.jikos.cz> (raw)
In-Reply-To: <1530791448-12743-1-git-send-email-nborisov@suse.com>
On Thu, Jul 05, 2018 at 02:50:48PM +0300, Nikolay Borisov wrote:
> @@ -921,8 +938,10 @@ int btrfs_quota_enable(struct btrfs_trans_handle *trans,
>
> ret = btrfs_insert_empty_item(trans, quota_root, path, &key,
> sizeof(*ptr));
> - if (ret)
> + if (ret) {
> goto out_free_path;
> + btrfs_abort_transaction(trans, ret);
Strange that gcc does not warn about that, and there's no warning switch
to detect dead code.
> @@ -3070,7 +3128,7 @@ static int __btrfs_qgroup_release_data(struct inode *inode,
> if (free && reserved)
> return qgroup_free_reserved_data(inode, reserved, start, len);
> extent_changeset_init(&changeset);
> - ret = clear_record_extent_bits(&BTRFS_I(inode)->io_tree, start,
> + ret = clear_record_extent_bits(&BTRFS_I(inode)->io_tree, start,
So the whitespace hunk still there?
> start + len -1, EXTENT_QGROUP_RESERVED, &changeset);
> if (ret < 0)
> goto out;
next prev parent reply other threads:[~2018-07-05 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:50 [PATCH v2] btrfs: qgroups: Move transaction management inside btrfs_quota_enable/disable Nikolay Borisov
2018-07-05 11:53 ` Nikolay Borisov
2018-07-05 14:29 ` David Sterba [this message]
2018-07-05 14:39 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705142929.GF3126@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox